Rollup of 3 perf-sensitive pull requests by JonathanBrouwer · Pull Request #164911 · rust-lang/rust

JonathanBrouwer · 2026-10-25T15:04:20Z

Successful merges:

Add various #[inline] annotations for simple functions on hot paths that don't get inlined #163845 (Add various #[inline] annotations for simple functions on hot paths that don't get inlined)
Don't emit allow attributes in try/contract desugaring #164122 (Don't emit allow attributes in try/contract desugaring)
create fast path for attributes created in builtin macro expansions #164260 (create fast path for attributes created in builtin macro expansions)

Failed merges:

Split LintLevelsBuilder::add into add_ast and add_hir #164790 (Split LintLevelsBuilder::add into add_ast and add_hir)

r? @ghost

Create a similar rollup

This avoids needing the overhead of a call before discovering that the `Cow` is already owned.

These show up in hot paths, and inlining should allow optimizing them.

These are simple wrappers but nonetheless don't get inlined and show up in hot paths.

These are simple wrappers.

…Simulacrum Add various `#[inline]` annotations for simple functions on hot paths that don't get inlined All of these are simple, likely to be optimizable once inlined into their caller, and found on hot paths in profiles (I used `clap_derive` for the profiling) as non-inlined functions.

…=hanna-kruppe Don't emit allow attributes in try/contract desugaring

@nnethercote

…rouwer,nnethercote create fast path for attributes created in builtin macro expansions Emitting attributes in rustc_builtin_macros involves creating an `ast::Attribute` and token trees, just to parse that into a parsed attribute almost immediately. This PR sidesteps that by creating a new `ast::Attribute` variant that does not do this. I've taken care to only do this for the derive and test macros, so that they never re-enter the parser. This results in some moderate performance gains. It'll also take away almost all of the regressions in rust-lang#164217 (comment) (see rust-lang#164281 (comment) for a perf run of this and that PR stacked) r? @nnethercote

JonathanBrouwer · 2026-10-25T15:04:40Z

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu,test-x86_64-gnu-llvm-22-3

rust-bors · 2026-10-25T15:04:43Z

📌 Commit 2690222 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 3 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3

…uwer Rollup of 3 perf-sensitive pull requests Successful merges: - #163845 (Add various `#[inline]` annotations for simple functions on hot paths that don't get inlined) - #164122 (Don't emit allow attributes in try/contract desugaring) - #164260 (create fast path for attributes created in builtin macro expansions) Failed merges: - #164790 (Split `LintLevelsBuilder::add` into `add_ast` and `add_hir`)

rust-log-analyzer · 2026-10-25T16:38:06Z

The job dist-apple-various failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] aho_corasick test:false 3.691
   Compiling regex-automata v0.4.14
error: linking with `cc` failed: exit status: 1
  |
  = note:  "cc" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/bootstrap-tools/release/build/libc/d8567d04e33e0bc0/out/rustceMfNHc/symbols.o" "<3 object files omitted>" "<sysroot>/lib/rustlib/aarch64-apple-darwin/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-lSystem" "-lc" "-lm" "-arch" "arm64" "-mmacosx-version-min=11.0.0" "-o" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/bootstrap-tools/release/build/libc/d8567d04e33e0bc0/out/build_script_build" "-Wl,-dead_strip" "-nodefaultlibs"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: clang: error: unable to execute command: Segmentation fault: 11
          clang: error: linker command failed due to signal (use -v to see invocation)
          Apple clang version 17.0.0 (clang-1700.6.3.2)
          Target: arm64-apple-darwin24.6.0
          Thread model: posix
          InstalledDir: /Applications/Xcode_26.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
          clang: note: diagnostic msg: 
          ********************
          
          PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
          Linker snapshot containing input(s) and associated run script(s) are located at:
          clang: note: diagnostic msg: /var/folders/nj/vtw8zd2j31d1gdrtntc5y4600000gn/T/linker-crash-e55b48
          clang: note: diagnostic msg: 
          
          ********************
          

[RUSTC-TIMING] build_script_build test:false 2.169

rust-bors · 2026-10-25T16:39:33Z

💔 Test for 5c46d6f failed: CI. Failed job:

auto - dist-apple-various (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-10-25T16:48:10Z

@bors retry
@bors try jobs=dist-apple-various

Rollup of 3 perf-sensitive pull requests try-job: dist-apple-various

rust-bors · 2026-10-25T18:20:47Z

This pull request was unapproved due to being closed.

rust-bors · 2026-10-25T19:08:13Z

☀️ Try build successful (CI)
Build commit: 828f835 (828f8351224b0a1f171e19da77ba8c540c37f90b)
Base parent: dc44e7f (dc44e7f2c436b6041742e138b9c2176f093196d5)

joshtriplett and others added 10 commits October 5, 2026 14:46

Inline Cow::to_mut

d3cefda

This avoids needing the overhead of a call before discovering that the `Cow` is already owned.

Inline Vec fold operations

48c4946

These show up in hot paths, and inlining should allow optimizing them.

Inline Copied fold operations

3e91052

These are simple wrappers but nonetheless don't get inlined and show up in hot paths.

Inline Cloned fold operations

d136cc4

These are simple wrappers.

Inline fold operations for Chain and Map, for performance

39c2880

Don't emit allow attributes in try/contract desugaring

e1663b6

create fast path for attributes created in builtin macro expansions

db2155b

Rollup merge of rust-lang#164122 - mejrs:no-new_ast_lowering-attrs, r…

9f2d25e

…=hanna-kruppe Don't emit allow attributes in try/contract desugaring

rust-bors Bot added the rollup A PR which is a rollup label Oct 25, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2026

JonathanBrouwer changed the title ~~Rollup of 3 pull requests~~ Rollup of 4 perf-sensitive pull requests Oct 25, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer changed the title ~~Rollup of 4 perf-sensitive pull requests~~ Rollup of 3 perf-sensitive pull requests Oct 25, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 25, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026

Auto merge of #164911 - JonathanBrouwer:rollup-I91jxgx, r=<try>

828f835

Rollup of 3 perf-sensitive pull requests try-job: dist-apple-various

JonathanBrouwer mentioned this pull request Oct 25, 2026

Deduplicate DefId encodings in the query cache #164300

Merged

JonathanBrouwer closed this Oct 25, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 25, 2026

Navigation Menu

Repository navigation

Rollup of 3 perf-sensitive pull requests - #164911

Rollup of 3 perf-sensitive pull requests#164911
JonathanBrouwer wants to merge 10 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-I91jxgx

JonathanBrouwer commented Oct 25, 2026

Uh oh!

JonathanBrouwer commented Oct 25, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-log-analyzer commented Oct 25, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

JonathanBrouwer commented Oct 25, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 25, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

JonathanBrouwer commented Oct 25, 2026

Uh oh!

JonathanBrouwer commented Oct 25, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-log-analyzer commented Oct 25, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

JonathanBrouwer commented Oct 25, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 25, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants