Skip to content

Rollup of 19 pull requests - #164922

Closed
JonathanBrouwer wants to merge 215 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-aQz95ip
Closed

JonathanBrouwer wants to merge 215 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-aQz95ip

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost

Create a similar rollup

nia-e and others added 30 commits September 29, 2026 19:34
After poll returned, the code treated any result without
`POLLERR`/`POLLHUP` as success. That's how Linux reports a failed
connect, but POSIX only specifies that the socket becomes writable once
the connection is established, not how a failed attempt is reported.
So on `illumos`, where a refused connect only sets `POLLOUT`,
`connect_timeout` returned `Ok` for a socket that never connected.

This keeps the behavior for `Linux` and `Android`, which can
rely on the status from `POLLERR`/`POLLHUP` as a fast path. Other cases
now check `self.take_error()?` to get the actual status.

`connect_timeout_error` test was tightened to expect an error.
…t/patch-1

Add note about std debug assertions disabling codegen tests
We need to refer to these rather often, but there hasn't been a common
place to locate this information.
Add a Developer Resources section with links to ABI documentation
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
…functions calling lower_attrs()

Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
Signed-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
GenMC now supports weak CASes and the failure ordering of CASes.
Hence, the CAS API is adjusted accordingly (no change in behavior
for now).
…folkertdev

Only recover if we may in `parse_expr_tuple_parens`

This removes the duplicate diagnostic in `tests/ui/macros/no-close-delim-issue-139248.rs`
rustc-dev-guide subtree update

Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@6986caf.

Created using https://github.com/rust-lang/josh-sync.

r? @ghost
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Oct 25, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 25, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu,test-x86_64-gnu-llvm-22-3

@rust-bors

rust-bors Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 7ab6cf9 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
Rollup of 19 pull requests


try-job: dist-various-1
try-job: test-various
try-job: test-x86_64-gnu-aux
try-job: test-x86_64-msvc-1
try-job: test-aarch64-apple-1
try-job: test-aarch64-apple-2
try-job: test-x86_64-mingw-1
try-job: test-i686-msvc
try-job: test-armhf-gnu
try-job: test-x86_64-gnu-llvm-22-3
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-x86_64-gnu-gcc-core-tests failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling rustc_pattern_analysis v0.0.0 (/checkout/compiler/rustc_pattern_analysis)
error[E0061]: this method takes 5 arguments but 4 arguments were supplied
    --> compiler/rustc_ast_lowering/src/path.rs:526:18
     |
 526 |             self.lower_attrs(segment_hir_id, &input.attrs, input.span, Target::Param);
     |                  ^^^^^^^^^^^--------------------------------------------------------- argument #5 of type `AstTarget<'_>` is missing
     |
note: method defined here
    --> compiler/rustc_ast_lowering/src/lib.rs:1152:8
     |
1152 |     fn lower_attrs(
     |        ^^^^^^^^^^^
...
1158 |         ast_target: AstTarget<'_>,
     |         -------------------------
help: provide the argument
     |
 526 |             self.lower_attrs(segment_hir_id, &input.attrs, input.span, Target::Param, /* AstTarget<'_> */);
     |                                                                                     +++++++++++++++++++++

For more information about this error, try `rustc --explain E0061`.
[RUSTC-TIMING] rustc_ast_lowering test:false 1.465
error: could not compile `rustc_ast_lowering` (lib) due to 1 previous error

Important

For more information how to resolve CI failures of this job, visit this link.

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-x86_64-gnu-aux failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling rustc_resolve v0.0.0 (/checkout/compiler/rustc_resolve)
error[E0061]: this method takes 5 arguments but 4 arguments were supplied
    --> compiler/rustc_ast_lowering/src/path.rs:526:18
     |
 526 |             self.lower_attrs(segment_hir_id, &input.attrs, input.span, Target::Param);
     |                  ^^^^^^^^^^^--------------------------------------------------------- argument #5 of type `AstTarget<'_>` is missing
     |
note: method defined here
    --> compiler/rustc_ast_lowering/src/lib.rs:1152:8
     |
1152 |     fn lower_attrs(
     |        ^^^^^^^^^^^
...
1158 |         ast_target: AstTarget<'_>,
     |         -------------------------
help: provide the argument
     |
 526 |             self.lower_attrs(segment_hir_id, &input.attrs, input.span, Target::Param, /* AstTarget<'_> */);
     |                                                                                     +++++++++++++++++++++

For more information about this error, try `rustc --explain E0061`.
[RUSTC-TIMING] rustc_ast_lowering test:false 1.506
error: could not compile `rustc_ast_lowering` (lib) due to 1 previous error
---
Currently active steps:
compile::Assemble { target_compiler: Compiler { stage: 1, host: x86_64-unknown-linux-gnu, forced_compiler: false } } at src/bootstrap/src/core/build_steps/tool.rs:375
compile::Rustc { target: x86_64-unknown-linux-gnu, build_compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, crates: [] } at src/bootstrap/src/core/build_steps/compile.rs:2341
Build completed unsuccessfully in 0:02:42
make: *** [Makefile:51: check-aux] Error 1
  local time: Sun Oct 25 18:29:08 UTC 2026
  network time: Sun, 25 Oct 2026 18:29:08 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 25, 2026
@rust-bors

rust-bors Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

PR #162530, which is a member of this rollup, was unapproved.

This rollup was thus unapproved.

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 25, 2026
@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 25, 2026
@rust-bors

rust-bors Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 6577233 failed: CI. Failed jobs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.