Repository navigation
Rollup of 20 pull requests - #164928
Open
JonathanBrouwer wants to merge 206 commits into
Open
Rollup of 20 pull requests#164928JonathanBrouwer wants to merge 206 commits into
JonathanBrouwer wants to merge 206 commits into
Conversation
After poll returned, the code treated any result without `POLLERR`/`POLLHUP` as success. That's how Linux reports a failed connect, but POSIX only specifies that the socket becomes writable once the connection is established, not how a failed attempt is reported. So on `illumos`, where a refused connect only sets `POLLOUT`, `connect_timeout` returned `Ok` for a socket that never connected. This keeps the behavior for `Linux` and `Android`, which can rely on the status from `POLLERR`/`POLLHUP` as a fast path. Other cases now check `self.take_error()?` to get the actual status. `connect_timeout_error` test was tightened to expect an error.
…t/patch-1 Add note about std debug assertions disabling codegen tests
We need to refer to these rather often, but there hasn't been a common place to locate this information.
Add a Developer Resources section with links to ABI documentation
Signed-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
GenMC now supports weak CASes and the failure ordering of CASes. Hence, the CAS API is adjusted accordingly (no change in behavior for now).
Modeling spurious failures is opt-in (see `-Zmiri-genmc-weak-cas-spurious-failures`), since Miri-GenMC cannot bound all retry loops involving weak CASes (e.g., the ones in the standard library).
update offload usage
…al-context-ref-readonly Use `eval_context_ref` where mutable access is not needed
…=Mark-Simulacrum Update `Ready` future expect messages Update the expect messages in `library/core/src/future/ready.rs` to follow `std::error` guidance according to rust-lang#159751.
…=Mark-Simulacrum Add IPv6 hop limit stubs to the motor OS net backend ### What - `hop_limit_v6` and set_hop_limit_v6` were defunct from motor backend, failing builds. ### Changes - For `TcpStream`, `UdpSocket` and `TcpListener` introduced stubs of above methods as currently they have no implementations at source. ### Verification - Build now passes for target Fixes rust-lang#164496
… r=Mark-Simulacrum Improve seek_read_buf_exact() test coverage to match seek_read_exact() Tracking issue: rust-lang#162868 This PR improves the test coverage for the Windows `FileExt` trait, adding tests for the `seek_read_buf_exact()` method, bringing it to the same level of test coverage as `seek_read_exact()`. No LLMs were used in writing this PR. Thanks!
…rk-Simulacrum docs: Two nitpick changes to `HashMap`, `BTreeMap` Entry API docs In the doc comment example of `Entry::insert_entry()` of `HashMap` and `BTreeMap`, the newly inserted value is not asserted -- only key is. This stands out, as doc comments of other insertion functions test both value and key. So, I have added two additional assertions to also test the newly inserted value.
…r=clarfonthey Expose FloatErrorKind Tracking issue: rust-lang#164793 Closes rust-lang/libs-team#683 (ACP) Right now this only makes the enum public and adds the method, but I'd like more input from libs team on what the `FloatErrorKind` should actually be extended with. r? libs
Migrate stable-specific run-make tests to UI tests Enabled by rust-lang#163664. I still kept the `stable_bare_rustc` function, as it could be genuinely useful (just not in the way it was used in run-make tests so far). Should help unblock rust-lang#162848. Note that the comment for the unstable target feature test was wrong (rust-lang#163428 (comment)). r? jieyouxu
…folkertdev Only recover if we may in `parse_expr_tuple_parens` This removes the duplicate diagnostic in `tests/ui/macros/no-close-delim-issue-139248.rs`
rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@6986caf. Created using https://github.com/rust-lang/josh-sync. r? @ghost
rustbot
added
A-run-make
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 25, 2026
Rollup of 20 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
Member
Author
|
@bors p=5 |
Contributor
Contributor
|
⌛ Testing commit d9c44bf with merge 8592206... Workflow: https://github.com/rust-lang/rust/actions/runs/40244543481 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 25, 2026
…uwer Rollup of 20 pull requests Successful merges: - #163730 (add tests over re-entrancy guarantees for 160776) - #164834 (miri subtree update) - #164849 (Use the span of the doctest code block fence for figuring out the line number) - #164883 (rustdoc: don't panic on a nested use group with no path prefix) - #164890 (Store cold blocks in a bitset instead of a Vec of bools) - #163458 (stabilize {Rc, Arc}::is_unique) - #163499 (vec: stabilise allocators for into_iter) - #163805 (std: check `SO_ERROR` after poll in `TcpStream::connect_timeout`) - #163816 (stabilize String::into_chars) - #163819 (Correct documentation of what `core::ops::Code` is.) - #163847 (add regression test for reborrow-invariant-type) - #164006 (Arduously fix typo) - #164009 (Update `Ready` future expect messages) - #164522 (Add IPv6 hop limit stubs to the motor OS net backend) - #164602 (Improve seek_read_buf_exact() test coverage to match seek_read_exact()) - #164772 (docs: Two nitpick changes to `HashMap`, `BTreeMap` Entry API docs) - #164794 (Expose FloatErrorKind) - #164802 (Migrate stable-specific run-make tests to UI tests) - #164899 (Only recover if we may in `parse_expr_tuple_parens`) - #164903 (rustc-dev-guide subtree update) Failed merges: - #164856 (Switch from `insta` to `expect-test` in bootstrap)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
SO_ERRORafter poll inTcpStream::connect_timeout#163805 (std: checkSO_ERRORafter poll inTcpStream::connect_timeout)core::ops::Codeis. #163819 (Correct documentation of whatcore::ops::Codeis.)Readyfuture expect messages #164009 (UpdateReadyfuture expect messages)HashMap,BTreeMapEntry API docs #164772 (docs: Two nitpick changes toHashMap,BTreeMapEntry API docs)parse_expr_tuple_parens#164899 (Only recover if we may inparse_expr_tuple_parens)Failed merges:
instatoexpect-testin bootstrap #164856 (Switch frominstatoexpect-testin bootstrap)r? @ghost
Create a similar rollup