Repository navigation
Remove redundant vec and duplicate indexing in find_noop_landing_pads - #164934
Merged
rust-bors[bot] merged 1 commit intoOct 26, 2026
Merged
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Contributor
|
r=me after squashing @bors delegate+ |
Contributor
|
✌️ @panstromek, you can now approve this pull request! If @hanna-kruppe told you to " |
hanna-kruppe
approved these changes
Oct 25, 2026
panstromek
force-pushed
the
cleanup-noop-landing-pads
branch
from
October 25, 2026 21:12
6197c3f to
1744ae8
Compare
Contributor
|
The CI failure should be solved by #164929 |
Contributor
Author
|
Thanks! @bors r=hanna-kruppe |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
❌ Commit 1744ae8 has been unapproved due to PR CI failure. Reapprove it with |
Contributor
|
@bors r+ force rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
On second thought, let’s not take risks by skipping CI when there’s no rush. r=me when CI is fixed, until then @bors r- |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. |
Contributor
Author
|
I think this should be fine now, the gcc revert was merged. @bors r=hanna-kruppe |
Contributor
|
❌ Cannot approve commit 1744ae8, because CI currently fails on this PR. Use |
panstromek
force-pushed
the
cleanup-noop-landing-pads
branch
from
October 26, 2026 06:41
1744ae8 to
ecf1622
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
ok, I rebased to trigger CI again @bors r=hanna-kruppe |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 26, 2026
…ds, r=hanna-kruppe Remove redundant vec and duplicate indexing in find_noop_landing_pads The original code looks like some refactoring artifact. The `map().collect()` chain is redundant because the `vec` is immediately turned into iterator again, and it throws away the `BasicBlockData` reference just to look it up again in the main loop.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
…uwer Rollup of 8 pull requests Successful merges: - #164955 (Use the updated buffer length in UEFI locate_handles) - #164958 (uefi: roll back env changes when `start_image` fails) - #164968 (thread_local::guard: update comments a bit) - #164303 (Remove the 'sub' method from 'At' and migrate to 'sub_raw') - #164674 (Use a NoSpan marker for region constraints without spans) - #164856 (Switch from `insta` to `expect-test` in bootstrap) - #164934 (Remove redundant vec and duplicate indexing in find_noop_landing_pads) - #164954 (Reduce `SpanData` use)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
…uwer Rollup of 8 pull requests Successful merges: - #164955 (Use the updated buffer length in UEFI locate_handles) - #164958 (uefi: roll back env changes when `start_image` fails) - #164968 (thread_local::guard: update comments a bit) - #164303 (Remove the 'sub' method from 'At' and migrate to 'sub_raw') - #164674 (Use a NoSpan marker for region constraints without spans) - #164934 (Remove redundant vec and duplicate indexing in find_noop_landing_pads) - #164954 (Reduce `SpanData` use) - #164970 (`rust-analyzer` subtree update)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
Rollup merge of #164934 - panstromek:cleanup-noop-landing-pads, r=hanna-kruppe Remove redundant vec and duplicate indexing in find_noop_landing_pads The original code looks like some refactoring artifact. The `map().collect()` chain is redundant because the `vec` is immediately turned into iterator again, and it throws away the `BasicBlockData` reference just to look it up again in the main loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code looks like some refactoring artifact. The
map().collect()chain is redundant because thevecis immediately turned into iterator again, and it throws away theBasicBlockDatareference just to look it up again in the main loop.