Repository navigation
borrowck: Explain implicit object lifetimes in static calls - #164935
Open
Dnreikronos wants to merge 4 commits into
Open
Dnreikronos wants to merge 4 commits into
Dnreikronos wants to merge 4 commits into
Conversation
Collaborator
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Dnreikronos
force-pushed
the
codex/borrowck_explicit_object_lifetime
branch
from
October 26, 2026 11:38
25924d9 to
13aef70
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
An omitted object bound can share the reference's lifetime, so E0521 points at the borrow even when the call requires a static trait object. Explain the lifetime source when suggesting an explicit object bound. Check callee bounds and trait lifetime arguments before offering an edit, and avoid making output lifetime elision ambiguous.
Dnreikronos
force-pushed
the
codex/borrowck_explicit_object_lifetime
branch
from
October 27, 2026 12:49
08a8141 to
9b983cc
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #162882
With
&dyn Error, the object lifetime defaults to the borrow's lifetime. Callingisneeds a'staticobject, but E0521 points at the borrow and makes it look like the reference has to be'statictoo. Adding+ 'staticto the object is enough for the example in the issue.This suggests
&(dyn Error + 'static)for the parameter and explains the implicit lifetime in the same help message, as requested in the issue. I think keeping the reason next to the edit makes the fix much easier to understand. When the trait's bounds supply the lifetime, the message explains that too.I kept the suggestion to arguments passed directly from parameters. The checks also look at the callee's bounds and the lifetimes in trait arguments, to avoid suggesting an object bound when the borrow itself needs to be
'staticor those trait lifetimes don't match. If the edit would make an elided return lifetime ambiguous, the diagnostic gives a note instead.