Rollup of 5 pull requests by JonathanBrouwer · Pull Request #164964 · rust-lang/rust

JonathanBrouwer · 2026-10-26T07:38:08Z

Successful merges:

Split LintLevelsBuilder::add into add_ast and add_hir #164790 (Split LintLevelsBuilder::add into add_ast and add_hir)
Remove ignore-unsafe tidy check in alloc/linklist #163952 (Remove ignore-unsafe tidy check in alloc/linklist)
Minor lints and performance improvements for LLDB visualizers #164691 (Minor lints and performance improvements for LLDB visualizers)
Cleanup rustdoc-html tests #164925 (Cleanup rustdoc-html tests)
Update actions/setup-python action to v7.1.0 #164941 (Update actions/setup-python action to v7.1.0)

@mejrs

Split `LintLevelsBuilder::add` into `add_ast` and `add_hir` Just making the code nicer r? @mejrs

…hrat011899 Remove ignore-unsafe tidy check in alloc/linklist This PR remove all `ignore-tidy-undocumented-unsafe` in `alloc/src/collections/linked_list.rs`. All unsafe call-sites are checked. Besides, this PR adds missing document comments for two unsafe functions(although they are private). If there exists anything need to be modified, I will update this PR.

Minor lints and performance improvements for LLDB visualizers Aside from the lints, this patch rearranges some things to make sure we only compute things like element types and type names once. There shouldn't be any user-facing effects from these changes.

@Urgau

…l-tests, r=Urgau Cleanup `rustdoc-html` tests r? @Urgau

…ns, r=Kobzol Update actions/setup-python action to v7.1.0 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-python](https://redirect.github.com/actions/setup-python) | action | minor | `v7.0.0` → `v7.1.0` | --- ### Release Notes <details> <summary>actions/setup-python</summary> ### [`v7.1.0`](https://redirect.github.com/actions/setup-python/releases/tag/v7.1.0) [Compare Source](https://redirect.github.com/actions/setup-python/compare/v7.0.0...v7.1.0) #### What's Changed ##### Enhancements - Add `mirror` and `mirror-token` inputs for custom Python distribution sources by [@&rust-lang#8203;luhenry](https://redirect.github.com/luhenry) in [#&rust-lang#8203;1302](https://redirect.github.com/actions/setup-python/pull/1302) - Improve error message clarity by [@&rust-lang#8203;v-lmvysakh](https://redirect.github.com/v-lmvysakh) in [#&rust-lang#8203;1351](https://redirect.github.com/actions/setup-python/pull/1351) ##### Dependency Upgrade - Upgrade browserslist from 4.28.2 to 4.28.9 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot) in [#&rust-lang#8203;1353](https://redirect.github.com/actions/setup-python/pull/1353) - Upgrade [@&rust-lang#8203;typescript-eslint/parser](https://redirect.github.com/typescript-eslint/parser) from 8.62.0 to 8.70.0 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot) in [#&rust-lang#8203;1343](https://redirect.github.com/actions/setup-python/pull/1343) - Upgrade eslint-plugin-jest from 29.15.2 to 29.16.6 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot) in [#&rust-lang#8203;1342](https://redirect.github.com/actions/setup-python/pull/1342) - Upgrade [@&rust-lang#8203;vercel/ncc](https://redirect.github.com/vercel/ncc) from 0.44.0 to 0.45.0 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot) in [#&rust-lang#8203;1357](https://redirect.github.com/actions/setup-python/pull/1357) - Upgrade [@&rust-lang#8203;types/semver](https://redirect.github.com/types/semver) from 7.7.1 to 7.8.0 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot) in [#&rust-lang#8203;1359](https://redirect.github.com/actions/setup-python/pull/1359) - Upgrade undici from 6.28.0 to 6.29.0 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot) in [#&rust-lang#8203;1364](https://redirect.github.com/actions/setup-python/pull/1364) - Upgrade ts-jest from 29.4.11 to 29.4.14 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot) in [#&rust-lang#8203;1361](https://redirect.github.com/actions/setup-python/pull/1361) - Upgrade brace-expansion from 5.0.9 to 5.0.12 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot) in [#&rust-lang#8203;1365](https://redirect.github.com/actions/setup-python/pull/1365) - Upgrade prettier from 3.8.4 to 3.9.9 and package.json from 7.0.0 to 7.1.0 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot) in [#&rust-lang#8203;1363](https://redirect.github.com/actions/setup-python/pull/1363) - Upgrade [@&rust-lang#8203;typescript-eslint/eslint-plugin](https://redirect.github.com/typescript-eslint/eslint-plugin) from 8.62.0 to 8.71.1 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot) in [#&rust-lang#8203;1369](https://redirect.github.com/actions/setup-python/pull/1369) - Upgrade actions/checkout from 7.0.0 to 7.0.1 by [@&rust-lang#8203;dependabot](https://redirect.github.com/dependabot) in [#&rust-lang#8203;1345](https://redirect.github.com/actions/setup-python/pull/1345) - Upgrade cache to 6.3.0 by [@&rust-lang#8203;v-HarithaVattikuti](https://redirect.github.com/v-HarithaVattikuti) in [#&rust-lang#8203;1370](https://redirect.github.com/actions/setup-python/pull/1370) - Resolve Basic Validation audit failures by [@&rust-lang#8203;v-HarithaVattikuti](https://redirect.github.com/v-HarithaVattikuti) in [#&rust-lang#8203;1347](https://redirect.github.com/actions/setup-python/pull/1347) - Resolve npm audit failures by [@&rust-lang#8203;v-HarithaVattikuti](https://redirect.github.com/v-HarithaVattikuti) in [#&rust-lang#8203;1350](https://redirect.github.com/actions/setup-python/pull/1350) #### New Contributors - [@&rust-lang#8203;luhenry](https://redirect.github.com/luhenry) made their first contribution in [#&rust-lang#8203;1302](https://redirect.github.com/actions/setup-python/pull/1302) **Full Changelog**: <actions/setup-python@v7.0.0...v7.1.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - Between 12:00 AM and 03:59 AM, only on Monday (`* 0-3 * * 1`) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/rust-lang/rust).

JonathanBrouwer · 2026-10-26T07:38:16Z

@bors r+ p=5 force

rust-bors · 2026-10-26T07:38:19Z

📌 Commit 52024b5 has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-10-26T10:43:20Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 2h 59m 19s
Pushing 019b59d to main...

github-actions · 2026-10-26T10:46:05Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing aaf324d (parent) -> 019b59d (this PR)

Test differences

Show 137 test diffs

Stage 1

[rustdoc-html] tests/rustdoc-html/dyn-compatibility.rs: pass -> [missing] (J0)
[rustdoc-html] tests/rustdoc-html/ensure-src-link.rs: pass -> [missing] (J0)
[rustdoc-html] tests/rustdoc-html/final-trait-method.rs: pass -> [missing] (J0)
[rustdoc-html] tests/rustdoc-html/hide-unstable-trait.rs: pass -> [missing] (J0)
[rustdoc-html] tests/rustdoc-html/impossible-default.rs: pass -> [missing] (J0)
[rustdoc-html] tests/rustdoc-html/trait/dyn-compatibility.rs: [missing] -> pass (J0)
[rustdoc-html] tests/rustdoc-html/trait/ensure-src-link.rs: [missing] -> pass (J0)
[rustdoc-html] tests/rustdoc-html/trait/final-trait-method.rs: [missing] -> pass (J0)
[rustdoc-html] tests/rustdoc-html/trait/hide-unstable-trait.rs: [missing] -> pass (J0)
[rustdoc-html] tests/rustdoc-html/trait/impossible-default.rs: [missing] -> pass (J0)

Stage 2

[rustdoc-html] tests/rustdoc-html/dyn-compatibility.rs: pass -> [missing] (J1)
[rustdoc-html] tests/rustdoc-html/final-trait-method.rs: pass -> [missing] (J1)
[rustdoc-html] tests/rustdoc-html/hide-unstable-trait.rs: pass -> [missing] (J1)
[rustdoc-html] tests/rustdoc-html/impossible-default.rs: pass -> [missing] (J1)
[rustdoc-html] tests/rustdoc-html/trait/dyn-compatibility.rs: [missing] -> pass (J1)
[rustdoc-html] tests/rustdoc-html/trait/final-trait-method.rs: [missing] -> pass (J1)
[rustdoc-html] tests/rustdoc-html/trait/hide-unstable-trait.rs: [missing] -> pass (J1)
[rustdoc-html] tests/rustdoc-html/trait/impossible-default.rs: [missing] -> pass (J1)
[rustdoc-html] tests/rustdoc-html/ensure-src-link.rs: pass -> [missing] (J2)
[rustdoc-html] tests/rustdoc-html/trait/ensure-src-link.rs: [missing] -> pass (J2)

Additionally, 117 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 019b59d8101bb3e141f1b880684747b4217beeb6 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-x86_64-gnu-miri: 50m 36s -> 1h 31m (+80.2%)
test-i686-gnu-1: 1h 27m -> 2h 34m (+77.2%)
test-x86_64-gnu-parallel-frontend: 1h 8m -> 2h 1m (+77.2%)
test-x86_64-gnu-llvm-22: 32m 43s -> 57m 58s (+77.2%)
test-x86_64-gnu-tools: 41m 52s -> 1h 12m (+72.0%)
test-x86_64-gnu-stdlib-semver-check: 10m 31s -> 17m 39s (+67.8%)
test-x86_64-gnu-gcc-core-tests: 11m 34s -> 18m 26s (+59.4%)
dist-arm-linux-musl: 1h 15m -> 1h 51m (+47.8%)
dist-armv7-linux: 1h 6m -> 1h 34m (+40.7%)
test-x86_64-msvc-1: 2h 46m -> 1h 40m (-39.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-bors · 2026-10-26T11:46:47Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#164790	Split `LintLevelsBuilder::add` into `add_ast` and `add_hir`	`24e1a68c77c7057bd2a2fad34b5ba1843da72de3` (link)
#163952	Remove ignore-unsafe tidy check in alloc/linklist	`41769f1af4028bab6bab2246bddc667769b24041` (link)
#164691	Minor lints and performance improvements for LLDB visualize…	`e08f2f056c7c57f5fae7c872070d7f7023038593` (link)
#164925	Cleanup `rustdoc-html` tests	`623a644ec0399f5be77a64af4fcd29679060fa4c` (link)
#164941	Update actions/setup-python action to v7.1.0	`2790709a03c74ea043c586c01562d9f3483e4107` (link)

parent commit: aaf324d50a

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

rust-timer · 2026-10-26T12:21:24Z

Finished benchmarking commit (019b59d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.1%]	5
Improvements ✅ (secondary)	-0.3%	[-0.5%, -0.0%]	28
All ❌✅ (primary)	-0.2%	[-0.2%, -0.1%]	5

Max RSS (memory usage)

Results (primary 0.3%, secondary -1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.5%, 1.2%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-1.3%, -0.5%]	3
Improvements ✅ (secondary)	-1.5%	[-2.5%, -0.4%]	2
All ❌✅ (primary)	0.3%	[-1.3%, 1.2%]	8

Cycles

Results (primary -0.1%, secondary -4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.4%, 2.1%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-1.5%, -0.4%]	9
Improvements ✅ (secondary)	-4.2%	[-7.6%, -0.7%]	2
All ❌✅ (primary)	-0.1%	[-1.5%, 2.1%]	14

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.2%]	67
Regressions ❌ (secondary)	0.1%	[0.0%, 0.3%]	56
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.2%]	67

Bootstrap: 488.092s -> 489.601s (0.31%)
Artifact size: 405.81 MiB -> 405.81 MiB (0.00%)

JonathanBrouwer · 2026-10-26T12:24:39Z

@rust-timer triage all

rust-timer · 2026-10-26T12:24:43Z

Running triage with 8 benchmarks

Triage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
For this rollup, these benchmarks are:

derive
enum-stress
include-blob
regex-automata-0.4.8
stm32f4-0.15.1
tuple-stress
ucd
unicode-normalization-0.1.24

#164790 `24e1a68` Split `LintLevelsBuilder::add` into `add_ast` and `add_hir`

Queued 24e1a68 with parent aaf324d, future comparison URL.
There are currently 5 preceding artifacts in the queue.
It will probably take at least ~4.1 hours until the benchmark run finishes.

#163952 `41769f1` Remove ignore-unsafe tidy check in alloc/linklist

Queued 41769f1 with parent aaf324d, future comparison URL.
There are currently 5 preceding artifacts in the queue.
It will probably take at least ~4.1 hours until the benchmark run finishes.

#164691 `e08f2f0` Minor lints and performance improvements for LLDB visualizers

Queued e08f2f0 with parent aaf324d, future comparison URL.
There are currently 6 preceding artifacts in the queue.
It will probably take at least ~4.2 hours until the benchmark run finishes.

#164925 `623a644` Cleanup `rustdoc-html` tests

Queued 623a644 with parent aaf324d, future comparison URL.
There are currently 18 preceding artifacts in the queue.
It will probably take at least ~7.5 hours until the benchmark run finishes.

#164941 `2790709` Update actions/setup-python action to v7.1.0

Queued 2790709 with parent aaf324d, future comparison URL.
There are currently 20 preceding artifacts in the queue.
It will probably take at least ~8.2 hours until the benchmark run finishes.

Walnut356 and others added 18 commits October 21, 2026 03:41

use fstrings instead of .format/placeholders

f9ca9d3

sort imports

d31e3d9

move work from update to __init__

879f7c7

lints

55c70d5

Move rustdoc-html tests in the right folder

7b173db

Improve tests/rustdoc-html/trait/impossible-default.rs

f0fa4d1

Update actions/setup-python action to v7.1.0

ecd20c0

Remove ignore-unsafe tidy check in alloc/linklist

1da334e

cache type names

1e6ad73

Split LintLevelsBuilder::add into add_ast and add_hir

45178a1

Inline is_automatically_derived_attr

879eda1

Inline is_doc_hidden

aba2992

Review

7aa7bb9

Rollup merge of rust-lang#164790 - JonathanBrouwer:split-add, r=mejrs

c193f9b

Split `LintLevelsBuilder::add` into `add_ast` and `add_hir` Just making the code nicer r? @mejrs

Rollup merge of rust-lang#164925 - GuillaumeGomez:cleanup-rustdoc-htm…

7221b89

…l-tests, r=Urgau Cleanup `rustdoc-html` tests r? @Urgau

rust-bors Bot added the rollup A PR which is a rollup label Oct 26, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2026

rust-bors Bot merged commit 019b59d into rust-lang:main Oct 26, 2026
15 checks passed

rustbot added this to the 1.101.0 milestone Oct 26, 2026

Navigation Menu

Repository navigation

Rollup of 5 pull requests - #164964

Rollup of 5 pull requests#164964
rust-bors[bot] merged 18 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-gEwXdy7

JonathanBrouwer commented Oct 26, 2026

Uh oh!

JonathanBrouwer commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 26, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 26, 2026

Stage 1

Stage 2

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

rust-timer commented Oct 26, 2026

Uh oh!

JonathanBrouwer commented Oct 26, 2026

Uh oh!

rust-timer commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

JonathanBrouwer commented Oct 26, 2026

Uh oh!

JonathanBrouwer commented Oct 26, 2026

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 26, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 26, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-bors Bot commented Oct 26, 2026

Uh oh!

rust-timer commented Oct 26, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented Oct 26, 2026

Uh oh!

rust-timer commented Oct 26, 2026

#164790 24e1a68 Split LintLevelsBuilder::add into add_ast and add_hir

#163952 41769f1 Remove ignore-unsafe tidy check in alloc/linklist

#164691 e08f2f0 Minor lints and performance improvements for LLDB visualizers

#164925 623a644 Cleanup rustdoc-html tests

#164941 2790709 Update actions/setup-python action to v7.1.0

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

#164790 `24e1a68` Split `LintLevelsBuilder::add` into `add_ast` and `add_hir`

#163952 `41769f1` Remove ignore-unsafe tidy check in alloc/linklist

#164691 `e08f2f0` Minor lints and performance improvements for LLDB visualizers

#164925 `623a644` Cleanup `rustdoc-html` tests

#164941 `2790709` Update actions/setup-python action to v7.1.0