[tgross35]

All other architecture families currently use a single macro for both
32- and 64-bit versions. Do the same for MIPS.

Tracking issue: #111188

r? libs

[rustbot]

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

Some changes occurred in std_detect

cc @Amanieu, @folkertdev, @sayantn

[tgross35]

Mips maintainers @Gelbpunkt @LukasWoodtli @chenx97 @709924470 @Cyanoxygen @Fearyncess could you confirm that this makes sense? The macro currently isn't very useful, but as long as most of the features are the same across the four arch variants then we may as well do the same thing as other arches.

[Gelbpunkt]

I believe this makes sense, yes. Most target features that may be listed here in the future should apply to both 32-bit and 64-bit MIPS. I believe r6 would make almost all optional features (like MSA) obsolete since they're implied, but I don't think that is worth splitting up (edit: and I guess softfloat targets may be a thing in the future).

[chenx97]

Looks like this target_arch comes from target triples, so the full list should be

echo mips{,64}{,el} mipsisa{32,64}r6{,el}

View changes since this review

[chenx97]

Get ready for some target triple madness

mips mipsel mips64 mips64el mipsisa32r6 mipsisa32r6el mipsisa64r6 mipsisa64r6el

[tgross35]

rust-lang/stdarch#2261 should make this less crazy