Skip to content

compiler-builtins subtree update - #165016

Merged
rust-bors[bot] merged 12 commits into
rust-lang:mainfrom
tgross35:update-builtins
Oct 28, 2026
Merged

rust-bors[bot] merged 12 commits into
rust-lang:mainfrom
tgross35:update-builtins

Conversation

@tgross35

@tgross35 tgross35 commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

tgross35 and others added 10 commits October 14, 2026 17:58
Starting with LLVM version 22 `nounwind` is now propagated from inline
assembly to functions containing it, meaning this workaround can now be
removed.

This reverts commit c4966f9b0d4323183933e98dea4d0a77f52c0e0a.

Link: llvm/llvm-project#150958
Link: rust-lang#144518
Since [1], these symbols are now mangled so need a lang item indicator
rather than `unsafe(no_mangle)`. This works on all platforms. It seems
like we can build without the other `rust_eh` symbols nowadays as well.

[1]: rust-lang#148413
Never build the versions included with LLVM's compiler-rt
library when the 'c' feature is enabled.

The rust version should be no worse than those included
with compiler-rt.
This updates the rust-version file to 8592206.
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Currently this seems to be way more frequent, so reduce the PR noise.
@rustbot rustbot added A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 27, 2026
@tgross35

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never p=1

@rust-bors

rust-bors Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

📌 Commit a22db91 has been tentatively approved by tgross35

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 27, 2026
@rust-bors

rust-bors Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

❌ Commit a22db91 has been unapproved due to PR CI failure. Reapprove it with @bors r+ force if you want to ignore the failure.

@rust-log-analyzer

This comment has been minimized.

`CARGO_BUILD_WARNINGS=deny` exposed a handful of warnings about unused
imports and dependencies. Fix everything before enabling in CI.
`RUSTFLAGS=-Dwarnings` is ignored by build scripts when `--target` is
specified, so our builds were never getting fully validated.  For now,
`CARGO_BUILD_WARNINGS` is the best way to improve this.
@tgross35

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never p=1

@rust-bors

rust-bors Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 25ca815 has been tentatively approved by tgross35

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 27, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Oct 27, 2026
compiler-builtins subtree update

Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@da91091.

Created using https://github.com/rust-lang/josh-sync.

r? @ghost
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-x86_64-gnu-llvm-22-3 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors Bot pushed a commit that referenced this pull request Oct 27, 2026
compiler-builtins subtree update

Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@da91091.

Created using https://github.com/rust-lang/josh-sync.

r? @ghost
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 27, 2026
@rust-bors

rust-bors Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

💔 Test for eb65e09 failed: CI. Failed job:

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-aarch64-apple-macos-26-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Important

For more information how to resolve CI failures of this job, visit this link.

@tgross35

Copy link
Copy Markdown
Member Author

The hosted runner lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

@bors retry

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Oct 28, 2026
compiler-builtins subtree update

Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@da91091.

Created using https://github.com/rust-lang/josh-sync.

r? @ghost
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors cancel
test-aarch64-apple-macos-26-2 failed 15 minutes ago and has been stuck cleaning orphaned processes ever since

@rust-bors

rust-bors Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #165056.

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Oct 28, 2026
compiler-builtins subtree update



Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@da91091.

Created using https://github.com/rust-lang/josh-sync.

r? @ghost
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-x86_64-gnu failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2026
@rust-bors

rust-bors Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

💔 Test for eacabf8 failed: CI. Failed job:

@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors retry

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2026
@rust-bors

rust-bors Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: tgross35
Duration: 3h 16m 44s
Pushing 92ffebe to main...

@rust-bors
rust-bors Bot merged commit 92ffebe into rust-lang:main Oct 28, 2026
16 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ab019e7 (parent) -> 92ffebe (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 92ffebeceaa0a071066f233873c2438e73d70fe7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. test-x86_64-rust-for-linux: 36m 9s -> 1h (+67.6%)
  2. test-x86_64-gnu-gcc-core-tests: 9m 59s -> 16m 23s (+64.1%)
  3. optional-test-x86_64-gnu-autodiff: 36m 2s -> 57m 38s (+59.9%)
  4. test-x86_64-mingw-1: 2h -> 2h 59m (+48.9%)
  5. dist-i686-linux: 1h 16m -> 1h 54m (+48.9%)
  6. test-x86_64-gnu-parallel-frontend: 1h 16m -> 1h 50m (+44.4%)
  7. dist-arm-linux-musl: 1h 18m -> 1h 50m (+41.7%)
  8. test-armhf-gnu: 1h 33m -> 55m 49s (-40.2%)
  9. dist-loongarch64-linux: 1h 32m -> 2h 7m (+37.7%)
  10. test-x86_64-gnu-miri: 1h 26m -> 54m (-37.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (92ffebe): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.5% [0.5%, 0.5%] 1
Regressions ❌
(secondary)
0.2% [0.1%, 0.2%] 7
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.1%] 3
All ❌✅ (primary) 0.5% [0.5%, 0.5%] 1

Max RSS (memory usage)

Results (primary -0.6%, secondary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.8% [0.8%, 0.9%] 4
Regressions ❌
(secondary)
5.5% [2.1%, 9.3%] 5
Improvements ✅
(primary)
-1.4% [-5.4%, -0.5%] 8
Improvements ✅
(secondary)
-3.4% [-4.8%, -0.7%] 4
All ❌✅ (primary) -0.6% [-5.4%, 0.9%] 12

Cycles

Results (primary -0.4%, secondary 1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.8% [0.4%, 1.2%] 6
Regressions ❌
(secondary)
3.8% [0.5%, 9.6%] 9
Improvements ✅
(primary)
-1.3% [-2.6%, -0.5%] 8
Improvements ✅
(secondary)
-4.2% [-6.7%, -0.7%] 4
All ❌✅ (primary) -0.4% [-2.6%, 1.2%] 14

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 488.323s -> 488.483s (0.03%)
Artifact size: 405.89 MiB -> 405.90 MiB (0.00%)

@rustbot rustbot added the perf-regression Performance regression. label Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants