Repository navigation
compiler-builtins subtree update - #165016
Conversation
Starting with LLVM version 22 `nounwind` is now propagated from inline assembly to functions containing it, meaning this workaround can now be removed. This reverts commit c4966f9b0d4323183933e98dea4d0a77f52c0e0a. Link: llvm/llvm-project#150958 Link: rust-lang#144518
Since [1], these symbols are now mangled so need a lang item indicator rather than `unsafe(no_mangle)`. This works on all platforms. It seems like we can build without the other `rust_eh` symbols nowadays as well. [1]: rust-lang#148413
Never build the versions included with LLVM's compiler-rt library when the 'c' feature is enabled. The rust version should be no worse than those included with compiler-rt.
This updates the rust-version file to 8592206.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@5d89371 New upstream ref: rust-lang/rust@8592206 Filtered ref: rust-lang/compiler-builtins@68d4f4a Upstream diff: rust-lang/rust@5d89371...8592206 This merge was created using https://github.com/rust-lang/josh-sync.
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Currently this seems to be way more frequent, so reduce the PR noise.
|
@bors r+ rollup=never p=1 |
|
❌ Commit a22db91 has been unapproved due to PR CI failure. Reapprove it with |
This comment has been minimized.
This comment has been minimized.
`CARGO_BUILD_WARNINGS=deny` exposed a handful of warnings about unused imports and dependencies. Fix everything before enabling in CI.
`RUSTFLAGS=-Dwarnings` is ignored by build scripts when `--target` is specified, so our builds were never getting fully validated. For now, `CARGO_BUILD_WARNINGS` is the best way to improve this.
|
@bors r+ rollup=never p=1 |
This comment has been minimized.
This comment has been minimized.
compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@da91091. Created using https://github.com/rust-lang/josh-sync. r? @ghost
|
The job Click to see the possible cause of the failure (guessed by this bot) |
compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@da91091. Created using https://github.com/rust-lang/josh-sync. r? @ghost
|
💔 Test for eb65e09 failed: CI. Failed job:
|
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
@bors retry |
This comment has been minimized.
This comment has been minimized.
compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@da91091. Created using https://github.com/rust-lang/josh-sync. r? @ghost
|
@bors cancel |
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #165056. |
This comment has been minimized.
This comment has been minimized.
compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@da91091. Created using https://github.com/rust-lang/josh-sync. r? @ghost
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test for eacabf8 failed: CI. Failed job:
|
|
@bors retry |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing ab019e7 (parent) -> 92ffebe (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 92ffebeceaa0a071066f233873c2438e73d70fe7 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (92ffebe): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.6%, secondary 1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -0.4%, secondary 1.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 488.323s -> 488.483s (0.03%) |
View all comments
Subtree update of
compiler-builtinsto rust-lang/compiler-builtins@da91091.Created using https://github.com/rust-lang/josh-sync.
r? @ghost