Skip to content

reduce redundant type-outlives constraints in large canonical responses - #165093

Draft
amirHdev wants to merge 2 commits into
rust-lang:mainfrom
amirHdev:next-solver-region-signature-dedup
Draft

amirHdev wants to merge 2 commits into
rust-lang:mainfrom
amirHdev:next-solver-region-signature-dedup

Conversation

@amirHdev

Copy link
Copy Markdown
Contributor

reduces redundant type-outlives constraints in large canonical responses by comparing region requirements for fully resolved types with region-only components

related to rust-lang/trait-system-refactor-initiative#308

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 28, 2026
@maxdexh

maxdexh commented Oct 28, 2026

Copy link
Copy Markdown
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 28, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 28, 2026
…r=<try>

reduce redundant type-outlives constraints in large canonical responses
@rust-bors

rust-bors Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 05e774a (05e774a585901d6deaa140d4bc4f4ed6f0768ca5)
Base parent: 41089d0 (41089d07a0a2afc16adfe28a760d94d73d7298a4)

@rust-timer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (05e774a): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.2%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.6% [0.4%, 1.1%] 11
Regressions ❌
(secondary)
0.8% [0.8%, 0.8%] 1
Improvements ✅
(primary)
-0.8% [-1.2%, -0.5%] 4
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [-1.2%, 1.1%] 15

Cycles

Results (primary 0.2%, secondary 1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.2% [0.6%, 2.3%] 7
Regressions ❌
(secondary)
1.6% [0.7%, 2.5%] 2
Improvements ✅
(primary)
-0.9% [-1.7%, -0.4%] 7
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [-1.7%, 2.3%] 14

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.1% [0.0%, 0.1%] 3
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.1% [0.0%, 0.1%] 3

Bootstrap: 490.666s -> 490.065s (-0.12%)
Artifact size: 405.86 MiB -> 406.15 MiB (0.07%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 28, 2026
@rust-bors

This comment has been minimized.

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants