Difficult to find 'How to structure your PR' #831

Activity

1. alex-griffiths commented on Aug 19, 2020

   

   alex-griffiths

   on Aug 19, 2020

   Last edited by alex-griffiths

   More actions

   As an addition to this, while it might not be strictly necessary, or even within the scope of the dev-guide, perhaps it could be helpful to include a brief comment (or even a quick overview of the required commands) about why the "No merge commits" point is made.

   For new contributors like myself, this wasn't immediately clear to me, and I'm sure it's the same for others.
2. jyn514

   added

   E-easyDifficulty: might be a good place for a beginnerDifficulty: might be a good place for a beginner

   on Sep 30, 2020
3. jyn514 commented on Sep 30, 2020

   

   jyn514

   on Sep 30, 2020

   MemberAuthor

   More actions

   perhaps it could be helpful to include a brief comment (or even a quick overview of the required commands) about why the "No merge commits" point is made.

   @alex-griffiths this was added as part of #890: https://rustc-dev-guide.rust-lang.org/git.html#no-merge-policy

   👍React with 👍1Reacted by Alex Griffiths
4. jieyouxu

   added

   A-metaArea: meta, about rustc or rustc-dev-guide itselfArea: meta, about rustc or rustc-dev-guide itself

   T-compilerRelevant to the compiler teamRelevant to the compiler team

   A-socialArea: social aspectsArea: social aspects

   A-contribution-workflowsArea: contribution workflowsArea: contribution workflows

   E-hardDifficulty: might require advanced knowledgeDifficulty: might require advanced knowledge

   and removed

   E-easyDifficulty: might be a good place for a beginnerDifficulty: might be a good place for a beginner

   on Nov 2, 2024