Skip to content

open issues when scheduled linkcheck fails - #2993

Merged
jyn514 merged 2 commits into
rust-lang:mainfrom
jyn514:track-broken-links
Sep 10, 2026
Merged

jyn514 merged 2 commits into
rust-lang:mainfrom
jyn514:track-broken-links

Conversation

@jyn514

@jyn514 jyn514 commented Aug 29, 2026

Copy link
Copy Markdown
Member

fixes #1956.
see jyn514#2 for example issues/comments it creates.
see https://github.com/rust-lang/rustc-dev-guide/actions/runs/33242644181/job/99074488060 for an example of the failures it'll link.

disclosure: most of the GHA crap here was generated by an LLM; it also found the GHA library, with prompting. i wrote the comments and PR description, and tested manually on my fork that it works.

i used an Action mostly because it seemed easy. i could port this to a Rust crate if you think it's better, seems mildly annoying to maintain but i don't feel strongly.

r? @jieyouxu

@rustbot rustbot added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Aug 29, 2026

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept wise this seems like a good idea so broken links actually show up somewhere. Unsure about the third-party action picked since it doesn't really see much usage?

^ I don't care if the impl is GHA or Rust crate since I don't think it really matters, it's more about the action used specifically

View changes since this review

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
- identify issues by label and title
- reuse an existing issue if it already exists
- use a bash script around `gh` so we don't add unvetted dependencies
- add tests for the bash script using a fake `gh` mock
@jyn514
jyn514 force-pushed the track-broken-links branch from 2df922a to e90126e Compare August 29, 2026 14:12

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits; the main logic seems sensible. We can always later go back to the third-party action or make this into a rust ci crate 🤷

Feel free to merge with the two things addressed, thanks

View changes since this review

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml
@jyn514
jyn514 enabled auto-merge September 10, 2026 15:13
@jyn514
jyn514 merged commit 71b709a into rust-lang:main Sep 10, 2026
4 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Sep 10, 2026
@jyn514
jyn514 deleted the track-broken-links branch September 14, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automated Dead Link Detection

3 participants