Allow streaming formatting#6957
Closed
mansiverma897993 wants to merge 3 commits into
Closed
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
Before we jump into a PR I think we should first have some design discussion over on the original feature request issue. The issue description lacks a lot of detail so it's not even clear to me right now that this implementation satisfies the feature that's being requested. This is also a fairly low priority item. I'm going to close this PR for now. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements streaming formatting via the
--start-markerand--end-markercommand-line options.When both options are supplied, rustfmt reads from stdin streamingly, and detects blocks of Rust code enclosed by the start and end markers. Each block is formatted using the standard format_string mechanism and flushed to stdout immediately, followed by the end marker. This avoids the 30ms startup overhead on Windows for tools invoking rustfmt repeatedly.
An integration test is also included in
tests/rustfmt/main.rsto verify the functionality.