Skip to content

Detect dead code better #2730

Closed
Closed
Detect dead code better#2730
Labels
E-easyenhancementhelp wanted

Description

@rbtcollins
rbtcollins
opened on Apr 23, 2021

We should stop using 'pub' and instead use 'crate' within rustup. Rustup has no exported API, but having pub functions results in dead types and functions not being detected. rust-lang/rust#79061 is an example of this technique applied to rustdoc

Activity

  1. rbtcollins
    added
    enhancement
    E-easy
    help wanted
    on Apr 23, 2021

  2. 0xPoe commented on Apr 24, 2021

    @0xPoe
    0xPoe
    on Apr 24, 2021
    Member

    I am working on this.

  3. 0xPoe commented on May 21, 2021

    @0xPoe
    0xPoe
    on May 21, 2021
    Member

    @rustbot claim

  4. rustbot
    assigned
    0xPoe
    on May 21, 2021

  5. 0xPoe commented on Jun 20, 2021

    @0xPoe
    0xPoe
    on Jun 20, 2021
    Member
    • After most of the cleanup is done, we should globally introduce #! [deny(unreachable_pub)].
  6. 0xPoe
    removed their assignment
    on Jan 1, 2022

  7. 0xPoe commented on Jan 1, 2022

    @0xPoe
    0xPoe
    on Jan 1, 2022
    Member

    I think we can close it now. It's done.

  8. kinnison
    closed this as completedon Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    E-easyenhancementhelp wanted

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions