Use of $crate in macro patterns is questionable

See rust-lang/rust#99447 (comment)

The fact that $crate in the macro_rules LHS is accepted and glued into kw::DollarCrate is likely an accidental bug. The single use is an internal macro helper arm,

ndarray/src/slice.rs

Line 845 in f8522cf

    
           (@parse ::core::marker::PhantomData::<$crate::Ix0>, ::core::marker::PhantomData::<$crate::Ix0>, []) => {

which looking at the macro, should probably be written to take $in_dim:expr, $out_dim:expr, like the other arms anyway.

Simplify `s![]`

Given that there is no associated bug report here nor safety / soundness issues, I'm going to close for now. Feel free to re-open if necessary.

Navigation Menu

Repository navigation

Use of `$crate` in macro patterns is questionable #1194

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Use of $crate in macro patterns is questionable #1194

Description

Activity

akern40 commented on May 21, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Use of `$crate` in macro patterns is questionable #1194