Skip to content

Test wasm32 with and without simd128 in CI - #5

Merged
RagnarGrootKoerkamp merged 1 commit into
rust-seq:masterfrom
bede:wasm-ci
Oct 23, 2026
Merged

RagnarGrootKoerkamp merged 1 commit into
rust-seq:masterfrom
bede:wasm-ci

Conversation

@bede

@bede bede commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Run tests under wasm for both wasm32-wasip1 and wasm32-unknown-unknown with and without simd. Make packed-seq's rand dev-only so builds work for wasm32-unknown-unknown

Make packed-seq's rand dev-only so builds work for
wasm32-unknown-unknown as well as wasi target.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The dependency configuration, WASI runner, and CI matrix are consistent, with no unresolved blocking issues identified.

No open issues 🎉

What changed in this PR

Adds WebAssembly CI coverage with SIMD enabled and disabled, while keeping packed-seq’s random-generation support limited to development builds.

Changes:

  • Adds a Node.js WASI runner that forwards arguments, environment variables, and exit status.
  • Checks wasm32-unknown-unknown library builds and runs wasm32-wasip1 release tests for both SIMD configurations.
  • Disables packed-seq’s default features for normal builds and enables rand for development.
File Description
scripts/​wasi-node.mjs Adds the Node.js runner for WASI test binaries.
Cargo.toml Limits packed-seq’s random-generation support to development builds.
.github/​workflows/​rust.yml Adds WebAssembly checks and tests with and without SIMD.

Review effort: Balanced

@RagnarGrootKoerkamp

Copy link
Copy Markdown
Contributor

To document my understanding: we can cargo check under wasm32-unknown-unkown, but we can't test under that because it needs to run in some kind of environment. wasip1 provides that.

@RagnarGrootKoerkamp
RagnarGrootKoerkamp merged commit 849e6ab into rust-seq:master Oct 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants