Repository navigation
Test wasm32 with and without simd128 in CI - #5
Merged
Merged
Conversation
Make packed-seq's rand dev-only so builds work for wasm32-unknown-unknown as well as wasi target.
There was a problem hiding this comment.
🟢 Approval recommended
The dependency configuration, WASI runner, and CI matrix are consistent, with no unresolved blocking issues identified.
No open issues 🎉
What changed in this PR
Adds WebAssembly CI coverage with SIMD enabled and disabled, while keeping packed-seq’s random-generation support limited to development builds.
Changes:
- Adds a Node.js WASI runner that forwards arguments, environment variables, and exit status.
- Checks
wasm32-unknown-unknownlibrary builds and runswasm32-wasip1release tests for both SIMD configurations. - Disables packed-seq’s default features for normal builds and enables
randfor development.
| File | Description |
|---|---|
scripts/wasi-node.mjs |
Adds the Node.js runner for WASI test binaries. |
Cargo.toml |
Limits packed-seq’s random-generation support to development builds. |
.github/workflows/rust.yml |
Adds WebAssembly checks and tests with and without SIMD. |
Review effort: Balanced
Contributor
|
To document my understanding: we can |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run tests under wasm for both
wasm32-wasip1andwasm32-unknown-unknownwith and without simd. Make packed-seq's rand dev-only so builds work forwasm32-unknown-unknown