fix(ilm): preserve lifecycle extension fields - #355
Merged
Conversation
cxymds
commented
Aug 25, 2026
cxymds
commented
Aug 25, 2026
cxymds
commented
Aug 25, 2026
cxymds
commented
Aug 25, 2026
cxymds
commented
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Addresses rustfs/rustfs#6334, where
rc bucket lifecycle rule importaccepts MinIO-compatible lifecycle extensions but a subsequent export drops them.Summary of Changes
ExpiredObjectAllVersions,DelMarkerExpiration, object-size predicates, repeated current/noncurrent transitions, andNewerNoncurrentVersions.DelMarkerExpiration: falsecombined with an enabled form.<Error>envelopes cannot be treated as empty configurations.x-amz-bucket-region, and fresh SigV4 signing for every request.Verification
cargo fmt --all --checkgit diff --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspacemake pre-commit(workspace formatting, Clippy, tests, and doctests)CARGO_BUILD_JOBS=2 cargo test -p rc-core --lib lifecycle::tests --no-fail-fastCARGO_BUILD_JOBS=2 cargo test -p rc-s3 --lib lifecycle --no-fail-fastCARGO_BUILD_JOBS=2 cargo test -p rustfs-cli --lib lifecycle --no-fail-fast017ffb92f; the fixed client preserves both lifecycle extensions.Adversarial review verdicts
lifecycle_xml_request/xml_request_once; no unrelated paths changed.Impact
Risks / Rollback