Repository navigation
fix(browser): continue loading after empty object pages - #257
Merged
Merged
Conversation
GatewayJ
requested review from
cxymds
and
a balanced review from Copilot
and removed request for
cxymds
October 7, 2026 05:07
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The central observer retry and resume behavior lacks automated behavioral coverage.
Review effort: Balanced
Findings: 1
What changed in this PR
Fixes Object Browser pagination when protected listings return empty pages with continuation tokens.
Changes:
- Adds a partial empty-page state and preserves pagination controls.
- Resumes viewport loading after requests while preventing automatic failure retries.
- Adds state tests and UI review evidence.
| File | Description |
|---|---|
components/object/list.tsx |
Updates pagination UI and observer lifecycle. |
lib/object-list-state.ts |
Adds the partial display state. |
tests/lib/object-list-state.test.ts |
Tests empty-page state resolution. |
tests/lib/object-list-source.test.js |
Updates pagination source assertions. |
docs/ui-review/register.md |
Records the UI fix and evidence. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cxymds
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Object Browser stops on an empty protected-listing page even when RustFS returns a continuation token. Keep the next-page controls available, distinguish a partial listing from an empty bucket, and resume viewport-driven loading when the current request finishes. Failed append requests retain manual retry without an automatic retry loop.
Type of Change
Testing
Validated commit
7ab8480: frozen install, type-check, lint, format check, all 636 tests, andgit diff --checkpassed on Node 22.Automated hook tests mount the production
useObjectListPaginationwith React and a mockedIntersectionObserverand append request. They cover resuming after loading clears, disconnecting during loading, stopping automatic retries after errors, and explicit retry.happy-domis a development-only dependency for these DOM tests, andtest:runincludes the hook suite. Mutation checks confirm that removing the loading dependency or error guard makes the corresponding test fail.Real Next.js UI with deterministic S3 network fixtures reproduced the original failure on main and verified two empty pages followed by a visible object, final empty results, append failure and keyboard retry, manual loading without IntersectionObserver, and rejection of stale responses after a prefix change. Desktop, mobile, light, and dark states were inspected. Fixtures do not establish the original reporter's exact deployment cause.
Checklist
Related Issues
Fixes https://github.com/rustfs/backlog/issues/2730
Related report: rustfs/rustfs#8116
Screenshots (if applicable)
Same page and S3 response sequence, captured from the real UI with network fixtures. Screenshot assets are kept outside the implementation diff.
Additional Notes
Independent reviewer/simplifier found no actionable issues. The change preserves S3 request parameters, backend filtering, existing search behavior, and response scope guards.