fix: provision homepage metrics KV explicitly - #73
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
rustfs-com | 8466821 | Commit Preview URL Branch Preview URL |
Aug 02 2026, 03:17 AM |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the deploy-homepage-metrics GitHub Actions workflow to ensure the Cloudflare Workers KV namespace used by the homepage metrics worker is explicitly provisioned (and injected into a generated Wrangler config) before deployment.
Changes:
- Adds a step to validate required Cloudflare repository secrets and verify Wrangler authentication.
- Adds a provisioning step that creates (if needed) and resolves the KV namespace ID, then generates
wrangler.deploy.jsoncwith the resolved KV namespace ID. - Switches deployment to use the generated
wrangler.deploy.jsoncconfig.
Suppressed comments (1)
.github/workflows/deploy-homepage-metrics.yml:84
- Same issue as above: this second
wrangler kv namespace listcall is also parsed byjqand needs--jsonto avoid non-JSON table output.
namespaces_json="$(pnpm exec wrangler kv namespace list)"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: | | ||
| set -euo pipefail | ||
|
|
||
| namespaces_json="$(pnpm exec wrangler kv namespace list)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: provision homepage metrics KV explicitly