Repository navigation
Conversation
Show the cursor screen detection toggle as "Move window to display where cursor is" under Across Display Settings, instead of only when the hidden default is already on. Test helpers now pin the cursor screen detection setting, so the display cycle tests no longer depend on the machine's own preferences.
Kiizon
force-pushed
the
cursor-display-targeting
branch
from
October 13, 2026 20:48
9dcb43a to
06f0fa6
Compare
Owner
|
Thanks for working on this! The Some quick background: There are a few files in Rectangle where all logic flows through, and they are the easiest places for changes to accumulate. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1908.
What it does
How
WindowHistorykeeps the frame of the display that was under the cursor for each window's last command.WindowManagerandShortcutManagercompare it with the display under the cursor now. If the cursor hasn't changed displays, the command works from the window's display, the same as with the setting off. This doesn't depend on the last recorded action, which Rectangle forgets whenever an app adjusts the frame it was given (common when moving across displays).Tests
withExecutionSettingsnow pinsuseCursorScreenDetection, so the existing display-cycle test doesn't pick up the machine's own setting.All 576 tests pass. Note: I built and tested with Xcode 26.0.1, using local-only changes (old app icon, macOS 14 deployment target, no macOS 27 menu API) that aren't part of this PR. It hasn't been built with Xcode 27.