refactor: move gate-check to consuming repos - #179
Merged
Conversation
Prevent inversion of control by having consuming repos implement gate-check before calling shared promote workflow. Changes: - Add vscode-find-nightly-candidate.yml (reusable workflow to find nightlies) - Simplify vscode-promote-prerelease.yml (publishing-only): - Remove find-nightly-candidate job (callers use vscode-find-nightly-candidate.yml) - Remove quality-gate job (callers use check-ci-status action inline) - Remove min-tag-age-days and required-ci-checks inputs - Make release-tag required (callers provide it) Pattern: Consuming repos now: 1. Call vscode-find-nightly-candidate.yml to find tag 2. Call check-ci-status action inline to validate CI (repo controls criteria) 3. Call vscode-promote-prerelease.yml to publish (publishing-only) Benefits: - Each repo controls its own promotion criteria - Shared workflows provide tools, not decisions - Gate-check visible in consuming repo's Actions UI Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
mshanemc
reviewed
Aug 27, 2026
| nightly-tag: ${{ steps.find.outputs.nightly-tag }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v6 |
Contributor
There was a problem hiding this comment.
does it need to specify which repo it's checking out? If it's the "calling" repo, does it need to receive a valid token for that (ex: in the case of a private repo) ?
Contributor
Author
There was a problem hiding this comment.
Good question, I double checked and dry run indeed pulled the correct repo (caller). Since the callers today are not private I think it should be fine as it is for now. Will comment for posterity.
mshanemc
approved these changes
Aug 27, 2026
mshanemc
left a comment
mshanemc
left a comment
Contributor
There was a problem hiding this comment.
approved, with questions. Might work but then not depending on the consumer.
Add comment noting that actions/checkout in reusable workflows checks out the calling repository and may need explicit token for private repos. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
madhur310
added a commit
to forcedotcom/salesforcedx-vscode
that referenced
this pull request
Aug 27, 2026
Update references from @ms/caller-call-ci-status-check to @main now that salesforcecli/github-workflows#179 has been merged. Changes: - vscode-find-nightly-candidate.yml@main - check-ci-status@main - vscode-promote-nightly-to-prerelease.yml@main Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent inversion of control by having consuming repos implement gate-check before calling shared promote workflow.
Changes:
Pattern: Consuming repos now:
Benefits: