Repository navigation
fix(web-store): require the exact Chrome Web Store origin - #188
Open
alexgleason wants to merge 1 commit into
Open
alexgleason wants to merge 1 commit into
alexgleason wants to merge 1 commit into
Conversation
The preload exposed chrome.webstorePrivate and chrome.management to any page whose URL starts with https://chromewebstore.google.com, and the IPC handlers accepted any sender origin with that prefix. Both also match lookalike hosts like https://chromewebstore.google.com.example.com, letting such a page install, list, and uninstall extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web store API is gated on a prefix match against
https://chromewebstore.google.comin two places:chrome.webstorePrivate/chrome.managementwhenlocation.href.startsWith('https://chromewebstore.google.com')senderFrame.origin.startsWith(WEBSTORE_URL)Both also match lookalike hosts such as
https://chromewebstore.google.com.example.com. A page on such a host gets the full store API:beginInstallinstalls any store extension (with no confirmation unless the app passesbeforeInstall), andmanagement.getAll/management.uninstalllist and remove installed extensions.This compares origins exactly in both places instead.
✅ By sending this pull request, I agree to the Contributor License Agreement of this project.