Repository navigation
refactor(explorer): drop renderers no core step feeds; object-store names for the UI's URLs - #107
Merged
Conversation
…ames for the UI's URLs The task-instance viewer rendered metadata that only an outside plugin writes: per-model user-simulation tabs (trajectory_urls, output_urls, snapshot_urls, delivery scores), the task_data milestones tab, the completed_runs tab and a verifier result_s3_uri "Results" download. Core writes none of it, so those tabs, their state, loaders and the RawJsonPanel / fetchRawS3Json helpers go, and the tab bar lists trajectories only. lib/materialize.ts had no importer left and goes too, with its smoke cases; the universe page's s3_url fallback was dead (the explorer API always returns object_url). Identifiers and comments name object URLs: s3Uri -> objectUrl, _entryS3Uri -> _entryObjectUrl, reviewerOverviewS3 -> reviewerOverviewUrl, and presignedUrl -> contentUrl (it is the same-origin content proxy, not a signed URL). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renderers no core step feeds. The task-instance viewer rendered metadata that only an outside plugin writes. Nothing in core produces any of these keys:
trajectory_urls,output_urls,snapshot_urls,deliveryscores, with trajectory / score / milestones / conversation-log subtabs);task_data.user_intentMilestones tab;completed_runstab;result_s3_uri"Results" download.Those tabs go, with their state, loaders,
RawJsonPanel,FetchStateandfetchRawS3Json, and the trigger-expansion state only they used. The tab bar now lists trajectories only, soBarDownloadloses itskind.Dead code.
lib/materialize.tshas had no importer since the task runner's embedded-host mode went; it and its smoke cases go.s3_urlfallback never fires, because the explorer API's universe files always carryobject_url.Names.
s3Uri→objectUrl(trajectory state, download entries, collected-zip jobs, artifact previews),_entryS3Uri→_entryObjectUrl,reviewerOverviewS3→reviewerOverviewUrl.presignedUrl→contentUrl: it is the same-origin/api/v1/objects/contentproxy, which a comment already called a leftover name.No release needed: the UI source is excluded from the wheel.
Testing
main(60 there). The usersim effect's missing-dependency warning goes; the newly unused trigger-expansion state was removed rather than left as a warning.bar-downloads.smoke.tsdrops the Results cases;trajectory-url.smoke.tsdrops thematerializecases.agent-env upon local stores, this branch vsmain):notes.txtshows its text through the renamedensureContentUrlpath. Same asmain.mainshows Completed Runs, Milestones and a "Download Results" entry; this branch shows Verifier Results and Task Run Context only.🤖 Generated with Claude Code
The PR appears safe to merge.
What we checked:
s3_urlinto theobject_urlfield the page reads, including when fetching a selected version.Summary
The task-instance viewer drops tabs and downloads driven by metadata that core does not write, while keeping core trajectories and verifier results. The PR also updates object-store naming in the UI and removes an unused materialization helper.
Reviews (1) · Last reviewed commit: "refactor(explorer): drop renderers no co..." · Reviewed by Greptile