Skip to content

refactor(explorer): drop renderers no core step feeds; object-store names for the UI's URLs - #107

Merged
earakely-scale merged 1 commit into
mainfrom
edgararakelyan/explorer-object-names
Oct 7, 2026
Merged

earakely-scale merged 1 commit into
mainfrom
edgararakelyan/explorer-object-names

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Renderers no core step feeds. The task-instance viewer rendered metadata that only an outside plugin writes. Nothing in core produces any of these keys:

  • per-model user-simulation tabs (trajectory_urls, output_urls, snapshot_urls, delivery scores, with trajectory / score / milestones / conversation-log subtabs);
  • the task_data.user_intent Milestones tab;
  • the completed_runs tab;
  • a verifier result_s3_uri "Results" download.

Those tabs go, with their state, loaders, RawJsonPanel, FetchState and fetchRawS3Json, and the trigger-expansion state only they used. The tab bar now lists trajectories only, so BarDownload loses its kind.

Dead code.

  • lib/materialize.ts has had no importer since the task runner's embedded-host mode went; it and its smoke cases go.
  • The universe page's s3_url fallback never fires, because the explorer API's universe files always carry object_url.

Names.

  • s3Uri → objectUrl (trajectory state, download entries, collected-zip jobs, artifact previews), _entryS3Uri → _entryObjectUrl, reviewerOverviewS3 → reviewerOverviewUrl.
  • presignedUrl → contentUrl: it is the same-origin /api/v1/objects/content proxy, which a comment already called a leftover name.
  • Comments say object URL / the store's CORS instead of S3 URI / bucket CORS.

No release needed: the UI source is excluded from the wheel.

Testing

  • Typecheck, static export: pass.
  • Lint: 59 warnings, all present on main (60 there). The usersim effect's missing-dependency warning goes; the newly unused trigger-expansion state was removed rather than left as a warning.
  • Smoke: 14 ran, 2 skipped on their allowed capability reasons, 0 failed. bar-downloads.smoke.ts drops the Results cases; trajectory-url.smoke.ts drops the materialize cases.
  • Chaos (built UI in headless Chrome, agent-env up on local stores, this branch vs main):
    • The twelve trajectory cases from feat(explorer): read prompt-response trajectory URLs under either key #102 render the same as before: S3-named / object-store / both / disagreeing / null keys, multi-turn with a failed turn, garbage values, four mixed responses collapsing to a dropdown, a missing object, core-written multi-turn.
    • Collected artifacts with a reviewer overview: the Overview tab's iframe loads the HTML through the content proxy, Collected Artifacts lists both files, and expanding notes.txt shows its text through the renamed ensureContentUrl path. Same as main.
    • An instance carrying every removed key: main shows Completed Runs, Milestones and a "Download Results" entry; this branch shows Verifier Results and Task Run Context only.
    • No uncaught exceptions in either build.

🤖 Generated with Claude Code

RetriggerConfidence Score: 5/5

The PR appears safe to merge.

What we checked:

  • Older universe files lose downloads: No. The universe API copies a stored s3_url into the object_url field the page reads, including when fetching a selected version.

Summary

The task-instance viewer drops tabs and downloads driven by metadata that core does not write, while keeping core trajectories and verifier results. The PR also updates object-store naming in the UI and removes an unused materialization helper.

  • Task-instance views keep core trajectories and drop plugin-only panes.
  • The viewer and artifact links use object-store names for file URLs.
  • The unused task-runner materializer and its smoke cases are removed.

Reviews (1) · Last reviewed commit: "refactor(explorer): drop renderers no co..." · Reviewed by Greptile

…ames for the UI's URLs

The task-instance viewer rendered metadata that only an outside plugin writes: per-model
user-simulation tabs (trajectory_urls, output_urls, snapshot_urls, delivery scores), the
task_data milestones tab, the completed_runs tab and a verifier result_s3_uri "Results" download.
Core writes none of it, so those tabs, their state, loaders and the RawJsonPanel / fetchRawS3Json
helpers go, and the tab bar lists trajectories only. lib/materialize.ts had no importer left and
goes too, with its smoke cases; the universe page's s3_url fallback was dead (the explorer API
always returns object_url).

Identifiers and comments name object URLs: s3Uri -> objectUrl, _entryS3Uri -> _entryObjectUrl,
reviewerOverviewS3 -> reviewerOverviewUrl, and presignedUrl -> contentUrl (it is the same-origin
content proxy, not a signed URL).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner October 7, 2026 23:38
@earakely-scale
earakely-scale merged commit 0607ea4 into main Oct 7, 2026
13 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/explorer-object-names branch October 7, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant