Repository navigation
ci: run the gateway integration tests as their own slow-tier check - #190
Merged
Merged
Conversation
AlexS-scale
marked this pull request as ready for review
October 14, 2026 15:44
earakely-scale
approved these changes
Oct 14, 2026
# Conflicts: # AGENTS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
CI did not run
tst/integration/env/gateway/gateway_test.py: both integration jobs used--ignoreon it.CONTRIBUTING.mdgave the reason as "needs an x86 Chromium build that the hosted runners do not have". The hosted runners are x86, and the tests pass on them.Without CI, two tests had become stale:
test_snapshot_clilooked for the clean snapshot without the image fingerprint. Snapshots are keyed on that fingerprint, so a lookup without it finds only legacy rows, and it found nothing. The test now does the same lookup asMultiEnv(multi_env.py:215). Its dependent,test_load_from_snapshot, now runs too.test_env_validator_taskdeploys and prompts the default A2A agent. It now skips with the capability reason when there is no model endpoint or no default agent, as the same tests intask_steps_test.pydo.Also,
test_gateway_triggers_nl_executorskipped each provider exceptmodal_vm, with a free-form reason that the skip policy refuses. It is now parametrized onmodal_vmonly, behind theremote_sandboxgate.The gateway tests take about as long as the remainder of the slow tier. Thus they run in parallel with it, as the new check
integration-local-gateway. One job definition gives both checks through a matrix withname. Thusintegration-local-slowkeeps its name, and the Docker set-up is not copied. Each check keeps the slow tier's 40-minute job limit. On the reviewed run,integration-local-gatewaytook 16 min 48 s andintegration-local-slowtook 17 min 33 s, so CI takes approximately the same time as before.Make
integration-local-gatewaya required check of themainruleset directly after this pull request merges. Do not do it before the merge: other open pull requests do not report this check, so GitHub would block them.How it was tested
On the reviewed CI run (run):
integration-local-gateway: 24 passed, 441 skipped. Each skip has a capability reason: 376remote_sandbox, 64mcp_server_sourcesand 1default_a2a_agent.integration-local-slow: 36 passed, 48 skipped.installerfails because of uv 0.13.1, onmaintoo. test(installer): compare the tool's files before uv rebuilds it #199 fixes that.On the current head (
c2ca3a6),integration-local-gatewaytook 18 min 6 s andintegration-local-slowtook 18 min 54 s. Each check passes exceptinstaller, for the same reason (run).Before the test fixes, the first run had the 2 failures above (run).


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Gateway integration tests now run beside the remaining slow tests as
integration-local-gateway.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Local backends workflow] --> B[integration-local: fast tests] A --> C[Shared slow-job definition] C --> D[integration-local-slow: other slow tests] C --> E[integration-local-gateway: gateway tests] D --> F[Check declared skips] E --> G[Check declared skips]Reviews (3) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile