Repository navigation
test(store): read the start time before the index build's release timer starts - #197
Merged
Merged
Conversation
earakely-scale
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
test_a_unique_index_is_awaited_however_long_it_buildsstarted its 0.3 s release timer before it read the start time. Thus the timer can release the index build less than 0.3 s afterstarted, and the>= 0.3assertion fails. On #193 and #194, CI measured 0.29995 s (#193, #194).The test now reads the start time first. The timer starts after
startedand releases the build at least 0.3 s after it starts, so the assertion always holds.How it was tested
The test ran 25 times locally: 25 passed.