Repository navigation
test(sandbox): fix the lint findings in the SmolVM tests - #212
Merged
Merged
Conversation
earakely-scale
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
mainfails theunitcheck since #157 (run). The CI of #157 ran before #192 added the lint step, so it did not find the 6 findings that #157 adds. Only theLintstep fails. Thus each pull request failsunit, and #193 does not publish the versions after #157 to PyPI.tst/manual/smol_vm_agent_check.pyandtst/manual/smol_vm_gateway_check.pyimport thelocal_stackfixture withnoqa: F401, so pyflakes reads each test that requests it as a redefinition (F811, 5 findings). They now import it with a same-name alias, as ci: lint with ruff's pyflakes rules, and fix what they find #192 did for the other modules that import this fixture.smol_vm_provider_test.pyhas an f-string without placeholders (F541). It is now a plain string.How it was tested
ruff check: no findings.smolextra to be collected, with or without this change.

Confidence Score: 5/5
The PR appears safe to merge; the three edits preserve test behavior.Summary
Fixes six lint findings in the SmolVM tests without changing their behavior.
Reviews (1) · Last reviewed commit: "test(sandbox): fix the lint findings in ..." · Reviewed by Greptile