Repository navigation
feat(task-steps): per-run step_overrides for the solver agent, model and effort - #217
Merged
Merged
Conversation
…and effort DeployAgentTaskStep reads a2a_agent_id / a2a_agent_version and PromptAgentTaskStep reads model / effort from the run's step_overrides for their own step id, ahead of the run-wide a2a_agent_id / agent_model / agent_effort overrides and the stored values. An overridden agent id takes the override's version (latest when unset), never the stored agent's pin. One task version can now run under a different solver harness and model per run while the user simulators and judges in the same task keep their stored agents; the run-wide override swaps every deploy_agent step at once. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DeployAgentTaskStepnow readsa2a_agent_id/a2a_agent_version, andPromptAgentTaskStepreadsmodel/effort, from the run'sstep_overridesentry for their own step id. These win over the run-widea2a_agent_id/agent_model/agent_effortoverrides and the stored values. An overridden agent id takes the override's version (latest when unset), never the stored agent's pin.Both steps use the existing
TaskStep.step_param_overridesseam; the hub and the explorer already forwardstep_overridesintouser_overrides.step_params, so no caller changes are needed.Why
A task that deploys several agents (a solver, a user simulator, judges) could so far be run under a different solver only by registering a new task version per harness, because the run-wide
a2a_agent_idoverride swaps everydeploy_agentstep at once. With a per-step override, one task version runs under any solver harness, model and effort, and the judges keep their stored agents.Example run body:
{"version": 17, "step_overrides": {"my-task-deploy-solver": {"a2a_agent_id": "codex-cli"}, "my-task-prompt": {"model": "gpt-6-astra", "effort": "xhigh"}}}Tests
tst/unit/task_step/test_step_overrides_agent_and_model.py(12 cases: stored values, step override with and without a version, version-only, step over run-wide, run-wide alone, other steps' overrides ignored; model and effort precedence, partial override, default-model fallback). The deploy-agent, prompt-agent and overrides unit tests intst/unit/task_steppass (272).🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Adds per-step agent, version, model, and effort overrides without changing stored task definitions.
No actionable issues were found. Tests were inspected, not run.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD Run["Run step_overrides"] --> Params["user_overrides.step_params"] Params --> Step["Select entry by step id"] Step --> Deploy["Resolve agent id and version"] Step --> Prompt["Resolve model and effort"] Deploy --> Lookup["A2AAgent.get"] Lookup --> Agent["Deploy selected agent"] Prompt --> Config["Send supported agent settings"] Prompt --> Response["Save selected model in PromptResponse"]Reviews (1) · Last reviewed commit: "feat(task-steps): per-run step_overrides..." · Reviewed by Greptile
Chaos
Timeboxed battery on three fresh Ubuntu VMs (24.04 amd64, 24.04 arm64, 22.04 amd64; Docker 29.9, Python 3.12), each with this branch and
maininstalled side by side, local stores and the local sandbox, two registered echo agents (echo,echo2) and a task of twodeploy_agentsteps (solver, judge) plus oneprompt_agentper agent. 114 runs in total, 38 per VM.a2a_agent_id; run-wideagent_model+agent_effortstep_overrideson the solver's deploy stepecho2, judge stays onechostep_overridesmodel/effort on the solver's prompt step, with a run-wideagent_modelseta2a_agent_id; version-only override; override for a step id not in the taskTask.runhalves with the context serialised in between (the worker's shape)mainbaseline, same harnessUnit tier
tst/unit/task_stepon the VMs: 1,642 pass on the branch, 1,630 onmain(the 12 new tests), with the same 3 environment-dependent failures on both (a local-Docker zip test and two MCP CLI codegen tests).