Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# AgentEnv Framework
<h1><img alt="AgentEnv Framework" src="https://raw.githubusercontent.com/scaleapi/agentenv-framework/main/assets/brand/readme-banner.png"></h1>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Older banners can change

The banner URL points to main, even when the README is published for a release tag. If someone later replaces or removes that file on main, visitors to an older PyPI release will see the wrong banner or a broken image. Point the image at a fixed revision so each release keeps its banner.

Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 1

Comment:
**Older banners can change**

The banner URL points to `main`, even when the README is published for a release tag. If someone later replaces or removes that file on `main`, visitors to an older PyPI release will see the wrong banner or a broken image. Point the image at a fixed revision so each release keeps its banner.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Cursor Fix in Claude Code Fix in Codex

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping main on purpose. The release tag doesn't exist when the README is written, and this PR's commit SHA gets replaced when it's squash-merged, so neither gives a stable URL at authoring time. The previous lockup used main URLs too. The banner is a brand asset under assets/brand/, and anyone who renames it should keep the old path.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That context makes sense. Given the banner is a stable, backward-compatible brand asset, the release tag is unavailable when the README is authored, and squash-merging invalidates the pre-merge commit SHA, keeping the main URL is the practical choice. I’m withdrawing this finding; no change is needed.


AgentEnv Framework is a Python SDK and CLI for building, deploying and running agentic environments and the tasks that grade agents inside them. Environments are containerized servers that speak the open `agentenv-framework-protocol`; it builds them into versioned images, deploys them behind a gateway, points an agent at them, and scores what the agent did.
AgentEnv Framework is a Python SDK and CLI for building, deploying and running agentic environments and the tasks that grade agents inside them. Environments are containerized servers that speak the open `agentenv-framework-protocol`; AgentEnv Framework builds them into versioned images, deploys them behind a gateway, points an agent at them, and scores what the agent did.

**Documentation: [www.agentenvframework.com/docs](https://www.agentenvframework.com/docs)** covers environments, artifacts, agents, tasks, the registry and plugins.

Expand Down
Binary file added assets/brand/readme-banner.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading