Skip to content

fix: catch JSONDecodeError in _throw_on_error - #2207

Merged
estellesoulard merged 2 commits into
scaleway:mainfrom
luxifer:hotfix/catch-not-json-response
Sep 24, 2026
Merged

fix: catch JSONDecodeError in _throw_on_error#2207
estellesoulard merged 2 commits into
scaleway:mainfrom
luxifer:hotfix/catch-not-json-response

Conversation

@luxifer

@luxifer luxifer commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

catch JSONDecodeError when API returns a code >= 400 and response is not JSON

@luxifer
luxifer requested a review from remyleone as a code owner September 24, 2026 09:10
@pypaut pypaut changed the title Catch JSONDecodeError in _throw_on_error fix: catch JSONDecodeError in _throw_on_error Sep 24, 2026
@estellesoulard
estellesoulard added this pull request to the merge queue Sep 24, 2026
Merged via the queue into scaleway:main with commit eaab921 Sep 24, 2026
79 checks passed
@luxifer
luxifer deleted the hotfix/catch-not-json-response branch September 24, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmrqs mmrqs mmrqs approved these changes
@estellesoulard estellesoulard estellesoulard approved these changes
@remyleone remyleone Awaiting requested review from remyleone remyleone is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luxifer @mmrqs @estellesoulard