Use literal seconds for lifecycle alert threshold defaults - #2778
Merged
bert-e merged 2 commits intoJul 21, 2026
Merged
Conversation
The threshold x-inputs used arithmetic defaults (10*60, 24*60*60, ...).
Arithmetic is valid inside the PromQL expressions, but the same values
are interpolated into the Go-template description annotations of the
LifecycleLateScan and LifecycleStalledScan alerts, and Go templates
have no '*' operator: when the consumer leaves an input unset, the
rendered annotation ('{{ 10*60 | humanizeDuration }}') fails to parse
with 'unexpected "*" in operand', prometheus-operator rejects the
rule group and aborts the whole Prometheus config sync, silently
disabling all alerting and any scrape config added afterwards.
The alerts CI never renders the defaults (the workflow supplies its
own threshold values), so this only surfaces in consumers that leave
inputs unset, e.g. Zenko with zenko-operator v1.8.13 which binds only
the latency thresholds.
Issue: BB-824
Contributor
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
This was referenced Jul 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.5 #2778 +/- ##
===================================================
- Coverage 75.47% 75.40% -0.08%
===================================================
Files 201 201
Lines 13917 13917
===================================================
- Hits 10504 10494 -10
- Misses 3403 3413 +10
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
delthas
requested review from
a team,
SylvainSenechal,
benzekrimaha and
maeldonn
July 21, 2026 09:11
benzekrimaha
approved these changes
Jul 21, 2026
Contributor
Author
|
/approve |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: approve |
SylvainSenechal
approved these changes
Jul 21, 2026
Contributor
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue BB-824. Goodbye delthas. The following options are set: approve |
eve-ci-cd
Bot
deployed
to
zenko/improvement/ZENKO-5314/days-0-expiration-ctst@2.16
July 21, 2026 10:01
Active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lifecycle alert threshold
x-inputsused arithmetic defaults (10*60,24*60*60, ...). Arithmetic is valid inside the PromQL expressions, but the same values are interpolated into the Go-templatedescriptionannotations of theLifecycleLateScanandLifecycleStalledScanalerts, and Go templates have no*operator: when the consumer leaves an input unset, the rendered annotation ({{ 10*60 | humanizeDuration }}) fails to parse withunexpected "*" in operand. prometheus-operator then rejects the rule group and aborts the entire Prometheus config sync — all alerting silently dies, and any ServiceMonitor reconciled afterwards is never scraped.This is the root cause of the deterministic
end2end-pra(PRA nominal case) and Kafka Cleaner CTST failures on every Zenko branch bumping backbeat >= 9.5.0-preview.2 (scality/Zenko#2461, scality/Zenko#2447, scality/Zenko#2451): zenko-operator v1.8.13 only binds the latency thresholds, so the conductor-scan inputs introduced by BB-740 fall back to their raw defaults.The alerts CI workflow does not catch this because it always supplies its own threshold values instead of rendering the file defaults.
Using literal seconds keeps the PromQL semantics identical and renders valid annotations (
{{ 600 | humanizeDuration }}→ "10 minutes").Issue: BB-824