Skip to content

CLDSRV-992: Fix missing s3 logs artifact for cloudserver - #6289

Open
anurag4DSB wants to merge 1 commit into
hotfix/9.0.32from
improvement/CLDSRV-992-9.0.32-s3c-s3-logs-artifact
Open

CLDSRV-992: Fix missing s3 logs artifact for cloudserver#6289
anurag4DSB wants to merge 1 commit into
hotfix/9.0.32from
improvement/CLDSRV-992-9.0.32-s3c-s3-logs-artifact

Conversation

@anurag4DSB

Copy link
Copy Markdown
Contributor

Backport of CLDSRV-942, from #6216 (30a06a609), cherry-picked unchanged: a one-line switch of the s3c-ft-tests job to the -testcoverage image. That fix landed on development/9.2 and reached 9.3, 9.4, 9.5 and hotfix/9.3.13, but never this branch.

Why it matters here: the plain image runs yarn start with output left on the container stdout, so cloudserver's log is never written to /artifacts and never uploaded. The -testcoverage image runs docker-test-with-coverage.sh, which does nyc yarn start > /artifacts/s3.log 2> /artifacts/s3-stderr.log, which is how every other functional job already captures it. Verified on real runs: a development/9.3 s3c bundle contains a 38 MB s3.log, while the sibling hotfix/9.2.36 bundle, on the same plain image this branch uses, has none. Any cloudserver-originated failure on this job is undiagnosable after the fact until this lands.

One behavioural note for the reviewer: this puts the hotfix s3c job on the nyc-instrumented image, the same one 9.3 and later already run for this job. Nothing else changes.

)

The s3c-ft-tests job runs cloudserver from the plain image, whose CMD is
`yarn start` with output left on the container's stdout, so cloudserver's log
is never written to /artifacts and never uploaded. Every other functional job
already uses the -testcoverage image, whose docker-test-with-coverage.sh runs
`nyc yarn start > /artifacts/s3.log 2> /artifacts/s3-stderr.log`.

CLDSRV-942 fixed this on development/9.2 and it reached 9.3, 9.4, 9.5 and
hotfix/9.3.13, but never this branch. It matters here: CLDSRV-992 row F8's
ServiceUnavailable on this branch could not be root-caused because nginx,
sproxyd and bucketd all logged clean and cloudserver's own log did not exist.

Backport of #6216

Issue: CLDSRV-992
@bert-e

bert-e commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Hello anurag4dsb,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/bypass_source_branch_lineage Bypass the cross-branch contamination check
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@anurag4DSB anurag4DSB changed the title CLDSRV-992: Fix missing s3 logs artifact for S3C CLDSRV-992: Fix missing s3 logs artifact for cloudserver Sep 10, 2026
@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.37%. Comparing base (ebd2abb) to head (e0eb758).
⚠️ Report is 1 commits behind head on hotfix/9.0.32.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           hotfix/9.0.32    #6289   +/-   ##
==============================================
  Coverage          83.37%   83.37%           
==============================================
  Files                189      189           
  Lines              12200    12200           
==============================================
  Hits               10172    10172           
  Misses              2028     2028           
Flag Coverage Δ
file-ft-tests 66.81% <ø> (-0.06%) ⬇️
kmip-ft-tests 26.99% <ø> (ø)
mongo-v0-ft-tests 68.20% <ø> (ø)
mongo-v1-ft-tests 68.13% <ø> (-0.09%) ⬇️
multiple-backend 35.68% <ø> (ø)
quota-tests 33.08% <ø> (ø)
quota-tests-inflights 34.18% <ø> (-0.04%) ⬇️
unit 67.55% <ø> (ø)
utapi-v2-tests 33.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants