CLDSRV-992: Fix missing s3 logs artifact for cloudserver - #6289
Open
anurag4DSB wants to merge 1 commit into
Open
CLDSRV-992: Fix missing s3 logs artifact for cloudserver#6289anurag4DSB wants to merge 1 commit into
anurag4DSB wants to merge 1 commit into
Conversation
) The s3c-ft-tests job runs cloudserver from the plain image, whose CMD is `yarn start` with output left on the container's stdout, so cloudserver's log is never written to /artifacts and never uploaded. Every other functional job already uses the -testcoverage image, whose docker-test-with-coverage.sh runs `nyc yarn start > /artifacts/s3.log 2> /artifacts/s3-stderr.log`. CLDSRV-942 fixed this on development/9.2 and it reached 9.3, 9.4, 9.5 and hotfix/9.3.13, but never this branch. It matters here: CLDSRV-992 row F8's ServiceUnavailable on this branch could not be root-caused because nginx, sproxyd and bucketd all logged clean and cloudserver's own log did not exist. Backport of #6216 Issue: CLDSRV-992
Contributor
Hello anurag4dsb,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## hotfix/9.0.32 #6289 +/- ##
==============================================
Coverage 83.37% 83.37%
==============================================
Files 189 189
Lines 12200 12200
==============================================
Hits 10172 10172
Misses 2028 2028
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
nicolas2bert
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of CLDSRV-942, from #6216 (
30a06a609), cherry-picked unchanged: a one-line switch of the s3c-ft-tests job to the-testcoverageimage. That fix landed on development/9.2 and reached 9.3, 9.4, 9.5 and hotfix/9.3.13, but never this branch.Why it matters here: the plain image runs
yarn startwith output left on the container stdout, so cloudserver's log is never written to/artifactsand never uploaded. The-testcoverageimage runsdocker-test-with-coverage.sh, which doesnyc yarn start > /artifacts/s3.log 2> /artifacts/s3-stderr.log, which is how every other functional job already captures it. Verified on real runs: a development/9.3 s3c bundle contains a 38 MBs3.log, while the sibling hotfix/9.2.36 bundle, on the same plain image this branch uses, has none. Any cloudserver-originated failure on this job is undiagnosable after the fact until this lands.One behavioural note for the reviewer: this puts the hotfix s3c job on the
nyc-instrumented image, the same one 9.3 and later already run for this job. Nothing else changes.