S3UTILS-248: move to Node 24 - #409
Closed
francoisferrand wants to merge 1 commit into
Closed
francoisferrand wants to merge 1 commit into
francoisferrand wants to merge 1 commit into
Conversation
Node 22 enters maintenance in October and 24 is the active LTS until 2028, so CI, the image and the engines floor all move to 24. Two native dependencies did not survive the ABI/toolchain change: - bucketclient 8.2.6 carried its own Arsenal 8.2.4, which pulled diskusage — unmaintained since 2021 and still on the pre-Node-24 NAN API. 8.2.10 takes Arsenal as a peer dependency, so we get a single copy (ours) and diskusage disappears from the tree. - node-rdkafka 2.x builds with C++17, while the Node 24 headers need C++20. Fixed in 3.x; the Producer API we use is unchanged. Issue: S3UTILS-248
Contributor
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/1.18 #409 +/- ##
=================================================
Coverage 45.32% 45.32%
=================================================
Files 88 88
Lines 6489 6489
Branches 1363 1363
=================================================
Hits 2941 2941
Misses 3502 3502
Partials 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
francoisferrand
marked this pull request as ready for review
September 25, 2026 07:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 22 enters maintenance in October and 24 is the active LTS until 2028, so CI, the image and the
enginesfloor all move to 24.Part of the org-wide Node 24 epic, OS-1155.
Two native dependencies didn't survive the ABI/toolchain change:
diskusage— unmaintained since 2021 and still using the NAN API that Node 24 removed, so there was no version to bump to. 8.2.10 takes Arsenal as a peer dependency instead, so we end up with a single copy (ours) anddiskusagedisappears from the tree.ProducerAPI we use is unchanged.No source changes were needed beyond that.
Validation
Run locally on Node 24.21.0:
yarn installcleanyarn lint -- --max-warnings 0cleanyarn test:unit— 32 suites, 456 tests passedcountItems,stalled,collectBucketMetricsAndUpdateBucketCapacityInfo) — 3 suites, 11 tests passeddocker buildsucceeds, andnode-rdkafka/arsenal/bucketclient/levelall load inside the imageThe functional suites needing the workbench stack (CloudServer/Vault) couldn't run locally — CI covers those.
Issue: S3UTILS-248