Repository navigation
Make Windows validation admission deterministic - #1003
Merged
Merged
Conversation
Capture exact repository, provider, tool, binding, manifest, and environment identities before Windows shell validation. Enforce stale-root and environment admission, strict no-BOM child output, and semantic source line-ending normalization without changing raw evidence. RED: pwsh -NoProfile -File Tools\windows\Tests\CandidateAdmission.Tests.ps1 -> 0 passed, 5 failed because admission and source helpers were absent. GREEN: focused Pester admission and isolation run -> 50 passed, 0 failed with positive execution. REGRESSION: pwsh -NoProfile -File Tools\windows\Invoke-ValidationRunnerContract.ps1 -> complete true, 695 required, 695 passed, 2354 executed, 0 errors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Reject UTF-16, BOM-prefixed, and OEM capture configurations in both OwnedByteStreamCapture and OwnedChildSupervisor. Bind the native cmd harness to UTF-8 and exercise LF text, invalid encodings, supervisor admission, and raw-byte preservation. RED: Build-CompiledValidationRunner plus ValidationRunner.exe --suite ownership -> ownership.managed.stream-encoding-contract failed before the enforcement fix. GREEN: focused ownership encoding tests -> stream-encoding-contract, raw-codec-bom, and bytes-utf8-bom passed; native harness safety 16/16 passed. REGRESSION: pwsh -NoProfile -File Tools\windows\Invoke-ValidationRunnerContract.ps1 -> complete true, 695 required, 695 passed, 2354 executed, 0 errors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Normalize nested manifest, binding, and source collections into typed scalar lists before hashing. Emit one record per path and reject newline-concatenated path values. Cover the three-manifest CI shape directly. RED: pwsh -NoProfile -File Tools\windows\Tests\CandidateAdmission.Tests.ps1 -> 5 passed, 1 failed because Get-WindowsShellCandidateManifestPaths was absent. GREEN: CandidateAdmission.Tests.ps1 -> 6 passed, 0 failed; merged isolation preflight -> 51 passed, 0 failed. REGRESSION: Invoke-ValidationRunnerContract.ps1 -> complete true, 695 required, 695 passed, 2354 executed, 0 errors; exact CI shell unit commands -> shards 3/3 PASS. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Use a pointer-only expected-modal route with retained process, direct owner, class, title, visibility and foreground checks. Return typed completion without Enter or selection fallback; preserve ordinary popup ownership and independent gate modal assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com> (cherry picked from commit 5beca8de64c692eebd9b25b2c2d277901e47c8ca)
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Windows validation admission and capture deterministic before expensive Windows qualification starts.
Changes
Test plan
RED: pwsh -NoProfile -File Tools\windows\Tests\CandidateAdmission.Tests.ps1 -> 0 passed, 5 failed because admission and source helpers were absent
GREEN: pwsh -NoProfile -File Tools\windows\Tests\CandidateAdmission.Tests.ps1 -> focused admission tests passed 50/50
REGRESSION: pwsh -NoProfile -File Tools\windows\Invoke-ValidationRunnerContract.ps1 -> complete true, 695 required, 695 passed, 2354 executed, 0 errors
Checklist
git commit -s) per the DCOmake test)make check)