Repository navigation
Qualify representative Windows sheets and dialogs - #1006
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an owned UIA geometry and PrintWindow conformance probe for the existing #768
Rename, Delete Loop, and New Loop sheet paths, and fix the live finding that an
empty New Loop Main form reserves a full attachment panel and incorrectly
overflows at the canonical 96 DPI fixture geometry.
Changes
Loop, New Loop Main, and New Loop Goal.
displaced content, no footer overlap, correct action order/visibility, and the
expected overflow state at the observed DPI.
and emit source hashes for
SheetFramework.zig,WindowsNativeDialogs.zig, andNativeForms.zig.direct-child ownership.
attachment section only after the first attachment exists, then relayout the
content extent immediately on add/remove.
Test plan
RED: from graphcode-windows run the pinned Zig test on src\NativeForms.zig with --test-filter "empty Main fits the canonical 96 DPI owner without scrolling" -> 0 passed, 1 failed at the no-overflow assertion; current candidate reserved 176 attachment pixels
GREEN: from graphcode-windows run the pinned Zig test on src\NativeForms.zig with --test-filter "empty Main fits the canonical 96 DPI owner without scrolling" -> 1/1 passed; extent and page both 620 pixels
REGRESSION: from graphcode-windows run the pinned Zig test on src\NativeForms.zig with x86_64-windows-msvc, user32, gdi32 and the Winghostty include -> 416/416 passed with 0 failed
pwsh -NoProfile -File Tools\windows\Build-CompiledValidationRunner.ps1-> build succeeded, 0 warnings, 0 errors.
uia-live-gate.ps1andValidationRunner.Tests.ps1-> 2/2 passed.validate.ps1 -Task windows-shell -ShellPart integration -SkipTrayLivestopped before UIA because the isolated daemon lane changed the user's default
~/.graphcode\graphcode-windows.log; classifiedenvironment/isolation.uia-live-gate.ps1launched the owned shell and completed cleanup, thenstopped before the Windows parity: Dialog and sheet framework: in-window dark sheets that size to content and never clip #768 scenes because the GitHub app retained foreground;
classified
permissions/time/desktop.retained product RED:
unexpected-overflow, with content796pixels andviewport
629pixels. The fix removes only the empty attachment reservation.--test-filter "new loop:"-> 29/29 passed.accessibility checks and the shard executable totals.
Candidate and evidence identity
NativeForms.zig=211F0C7A18DD90B5DC1B9F81073C54303F5DC3689F8CC84EED49919540B79F7D;uia-live-gate.ps1=3920F958317D6CF536CAF510C6AD1847D2B0A53793550451A53F178157E562E4;ValidationRunner.Tests.ps1=C4D93FF0A9A0A755AA646706CA685F1422F764D816EC652976F11866194F6256Stopping handoff
No technical blocker remains. Exact-head Windows integration passed on source commit
2a975f54f2655238de9dbbc0fa8424e5d7b7dc18; current merged HEAD is20542bdc619a8ad226fed15e6f0277b3cbb84d48. The retained Main observation reportscontent=[262,73,782,693],viewport=[262,73,782,693], andoverflow=false; Goal remainsoverflow=true. Every exact-head workflow checkis complete and green or path-skipped. Publication/merge authority remains with
the coordinator.
Checklist
git commit -s) per the DCOmake test)make check)