Skip to content

Qualify representative Windows sheets and dialogs - #1006

Merged
coneilen merged 3 commits into
mainfrom
coneilen-windows-dialog-sheet-framework-plan
Nov 12, 2026
Merged

coneilen merged 3 commits into
mainfrom
coneilen-windows-dialog-sheet-framework-plan

Conversation

@coneilen

@coneilen coneilen commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add an owned UIA geometry and PrintWindow conformance probe for the existing #768
Rename, Delete Loop, and New Loop sheet paths, and fix the live finding that an
empty New Loop Main form reserves a full attachment panel and incorrectly
overflows at the canonical 96 DPI fixture geometry.

Changes

  • Add bounded owner/host/viewport/content/action observations for Rename, Delete
    Loop, New Loop Main, and New Loop Goal.
  • Require exact native direct-child ownership, no host/client frame mismatch, no
    displaced content, no footer overlap, correct action order/visibility, and the
    expected overflow state at the observed DPI.
  • Capture owner and sheet images with PrintWindow, record byte counts and SHA-256,
    and emit source hashes for SheetFramework.zig, WindowsNativeDialogs.zig, and
    NativeForms.zig.
  • Add focused positive/negative geometry contracts and compiled native tests for
    direct-child ownership.
  • Keep the Attach action inline with the empty brief field. Expand the full
    attachment section only after the first attachment exists, then relayout the
    content extent immediately on add/remove.

Test plan

RED: from graphcode-windows run the pinned Zig test on src\NativeForms.zig with --test-filter "empty Main fits the canonical 96 DPI owner without scrolling" -> 0 passed, 1 failed at the no-overflow assertion; current candidate reserved 176 attachment pixels
GREEN: from graphcode-windows run the pinned Zig test on src\NativeForms.zig with --test-filter "empty Main fits the canonical 96 DPI owner without scrolling" -> 1/1 passed; extent and page both 620 pixels
REGRESSION: from graphcode-windows run the pinned Zig test on src\NativeForms.zig with x86_64-windows-msvc, user32, gdi32 and the Winghostty include -> 416/416 passed with 0 failed

  • pwsh -NoProfile -File Tools\windows\Build-CompiledValidationRunner.ps1
    -> build succeeded, 0 warnings, 0 errors.
  • PowerShell parse of uia-live-gate.ps1 and
    ValidationRunner.Tests.ps1 -> 2/2 passed.
  • Canonical
    validate.ps1 -Task windows-shell -ShellPart integration -SkipTrayLive
    stopped before UIA because the isolated daemon lane changed the user's default
    ~/.graphcode\graphcode-windows.log; classified environment/isolation.
  • Direct uia-live-gate.ps1 launched the owned shell and completed cleanup, then
    stopped before the Windows parity: Dialog and sheet framework: in-window dark sheets that size to content and never clip #768 scenes because the GitHub app retained foreground;
    classified permissions/time/desktop.
  • The exact-head PR integration run executed the Windows parity: Dialog and sheet framework: in-window dark sheets that size to content and never clip #768 Main scene and produced a
    retained product RED: unexpected-overflow, with content 796 pixels and
    viewport 629 pixels. The fix removes only the empty attachment reservation.
  • --test-filter "new loop:" -> 29/29 passed.
  • All three serial Windows shell unit shards passed, including 280/280 native
    accessibility checks and the shard executable totals.

Candidate and evidence identity

  • Tier(s): Tier A, Tier B
  • Branch: coneilen-windows-dialog-sheet-framework-plan
  • HEAD / tree: 20542bd / 52ad6768b770e0eb047345f80cc65c390207b389 (dirty)
  • Candidate hashes: NativeForms.zig=211F0C7A18DD90B5DC1B9F81073C54303F5DC3689F8CC84EED49919540B79F7D; uia-live-gate.ps1=3920F958317D6CF536CAF510C6AD1847D2B0A53793550451A53F178157E562E4; ValidationRunner.Tests.ps1=C4D93FF0A9A0A755AA646706CA685F1422F764D816EC652976F11866194F6256

Stopping handoff

No technical blocker remains. Exact-head Windows integration passed on source commit
2a975f54f2655238de9dbbc0fa8424e5d7b7dc18; current merged HEAD is
20542bdc619a8ad226fed15e6f0277b3cbb84d48. The retained Main observation reports
content=[262,73,782,693], viewport=[262,73,782,693], and
overflow=false; Goal remains overflow=true. Every exact-head workflow check
is complete and green or path-skipped. Publication/merge authority remains with
the coordinator.

Checklist

  • I have read the Contributing Guidelines
  • I have signed off my commits (git commit -s) per the DCO
  • Tests pass locally (make test)
  • Code follows the existing style (make check)
  • I added the test/contract before the implementation and observed the intended RED failure
  • The evidence tier is explicit and the frozen candidate tuple matches the cited evidence
  • Any failure was classified and preserved before correction or retry

coneilen and others added 3 commits November 11, 2026 18:21
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
@coneilen
coneilen merged commit b5f023e into main Nov 12, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant