Repository navigation
Expose Windows overview card actions - #1007
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose overview loop-card Reply/Inspect controls and cycle-role text as first-class UIA and hit-test targets, while preserving unwired recovery precedence and existing macOS-derived card paint.
Changes
Test plan
RED: & $env:GRAPHCODE_ZIG0152 test src\App.zig src\AccessibilityProvider.cpp src\FilePicker.c src\FolderPicker.c with the native provider flags --test-filter "loop card overview attention UIA publication" -> 1/1 executed; expected 2, found 0
GREEN: & $env:GRAPHCODE_ZIG0152 test src\App.zig src\AccessibilityProvider.cpp src\FilePicker.c src\FolderPicker.c with the native provider flags --test-filter "loop card overview attention UIA publication" -> 1/1 passed
REGRESSION: pwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -ShellPart unit -ShellTestShard 0 -ShellTestShardCount 3 -ShellTestManifest .ci-sections\shard-0.json -ShellValidationRoot C:\gc764-final-val-0 -> exited 0
Additional Tier A regression:
loop card parity chrome 764: 6/6 passed, zero skips.GraphCanvas.zig: 424 passed, 19 export skips, 0 failed.App.zig: 1736 passed, 19 skips, 0 failed.Candidate and evidence identity
coneilen-plan-windows-loop-cards-764e0a5579f3b470bede72294d661282a391c502aceand zmx785b3fd15dcafd1882b495c831a10f98c201b908.Stopping handoff
pwsh -NoProfile -File .\Tools\windows\validate.ps1 -Task windows-shell -SkipTrayLive -ShellPart integration -ShellValidationRoot C:\gcvC:\gcv; retained UIA failure sandboxC:\gcv\7c91cae620a44d899f7157c352f4d1e9\temp\gu-22b76e09753f40d8bba5796f518b3f69.Checklist
git commit -s) per the DCOmake test) — Windows-only change; Windows local evidence is listed above instead.make check) — macOSmake checkwas not run for this Windows-only slice.