Skip to content

Expose Windows overview card actions - #1007

Merged
coneilen merged 1 commit into
mainfrom
coneilen-plan-windows-loop-cards-764
Nov 12, 2026
Merged

coneilen merged 1 commit into
mainfrom
coneilen-plan-windows-loop-cards-764

Conversation

@coneilen

Copy link
Copy Markdown
Collaborator

Summary

Expose overview loop-card Reply/Inspect controls and cycle-role text as first-class UIA and hit-test targets, while preserving unwired recovery precedence and existing macOS-derived card paint.

Changes

  • Add GraphCanvas overview attention-action hit testing for exact painted bounds across zoom.
  • Publish overview Reply/Inspect and cycle-reason UIA elements with stable existing identities and correct invokability.
  • Route overview action activation through the existing owning-loop workspace path.
  • Add focused GraphCanvas and App coverage for Reply, Inspect, cycle roles, zoom, unwired precedence, and stable UIA invocation.

Test plan

RED: & $env:GRAPHCODE_ZIG0152 test src\App.zig src\AccessibilityProvider.cpp src\FilePicker.c src\FolderPicker.c with the native provider flags --test-filter "loop card overview attention UIA publication" -> 1/1 executed; expected 2, found 0
GREEN: & $env:GRAPHCODE_ZIG0152 test src\App.zig src\AccessibilityProvider.cpp src\FilePicker.c src\FolderPicker.c with the native provider flags --test-filter "loop card overview attention UIA publication" -> 1/1 passed
REGRESSION: pwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -ShellPart unit -ShellTestShard 0 -ShellTestShardCount 3 -ShellTestManifest .ci-sections\shard-0.json -ShellValidationRoot C:\gc764-final-val-0 -> exited 0

Additional Tier A regression:

  • Focused GraphCanvas overview action/role test: 1/1 passed.
  • Native-AA loop card parity chrome 764: 6/6 passed, zero skips.
  • Full GraphCanvas.zig: 424 passed, 19 export skips, 0 failed.
  • Full App.zig: 1736 passed, 19 skips, 0 failed.
  • CI-equivalent unit shards 1 and 2: exited 0.
  • Unit shard 0's exact post-correction rerun: exited 0.
  • Integration build, smoke, daemon round-trip, tray contracts: passed before the native UIA desktop gate.
  • Integration live UIA: stopped before the product assertions because the foreign GitHub Tauri window retained foreground; cleanup and DPI restoration completed, and no product assertion failed.

Candidate and evidence identity

  • Tier(s): Tier A, Tier B
  • Branch: coneilen-plan-windows-loop-cards-764
  • HEAD / tree: e3b8e18 / aa3b00a5a05272c869a29e5f914f3f3fbfacb520 (clean)
  • Candidate hashes: e3b8e18 for the committed App/GraphCanvas candidate, with Winghostty e0a5579f3b470bede72294d661282a391c502ace and zmx 785b3fd15dcafd1882b495c831a10f98c201b908.

Stopping handoff

  • Next exact command: pwsh -NoProfile -File .\Tools\windows\validate.ps1 -Task windows-shell -SkipTrayLive -ShellPart integration -ShellValidationRoot C:\gcv
  • Positive count: unit shards 0/1/2 exited 0; focused App 1/1; focused GraphCanvas 1/1; native paint 6/6; full App 1736 passed plus 19 skips; full GraphCanvas 424 passed plus 19 skips.
  • Permissions / time / desktop: A dedicated foreground desktop is required for the live UIA lane; the current GitHub Tauri window remained foreign foreground.
  • Blocker category: permissions/time/desktop
  • Evidence paths: short integration sandbox C:\gcv; retained UIA failure sandbox C:\gcv\7c91cae620a44d899f7157c352f4d1e9\temp\gu-22b76e09753f40d8bba5796f518b3f69.
  • Stopping condition: stop until a separately authorized live desktop can give the GraphCode shell foreground; then rerun the exact integration command on the same immutable candidate.
  • Publication authority: coordinator/operator only; this session did not push, open, edit, merge, or publish a PR.

Checklist

  • I have read the Contributing Guidelines
  • I have signed off my commits (git commit -s) per the DCO
  • Tests pass locally (make test) — Windows-only change; Windows local evidence is listed above instead.
  • Code follows the existing style (make check) — macOS make check was not run for this Windows-only slice.
  • I added the test/contract before the implementation and observed the intended RED failure
  • The evidence tier is explicit and the frozen candidate tuple matches the cited evidence
  • Any failure was classified and preserved before correction or retry

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
@coneilen
coneilen merged commit 49d9901 into main Nov 12, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant