Skip to content

Add Windows sidebar workspace footer - #1008

Merged
coneilen merged 3 commits into
mainfrom
coneilen-plan-issue-767-sidebar-window-layout
Nov 12, 2026
Merged

coneilen merged 3 commits into
mainfrom
coneilen-plan-issue-767-sidebar-window-layout

Conversation

@coneilen

Copy link
Copy Markdown
Collaborator

Summary

Adds the visible, actionable workspace footer to the Windows sidebar and
reuses the existing native workspace lifecycle commands. This is a bounded
Refs #767 slice for the footer/current-workspace action only; it does not
close the structured workspace-summary popover, whole-sidebar layout, terminal
reservation, or the issue's other acceptance boxes.

Changes

  • Paint a current-workspace footer with divider, stack glyph, truncated name,
    and disclosure chevrons inside the Sidebar's reserved 36-DIP bottom region.
  • Use one Sidebar-owned geometry helper for paint, pointer hit testing, UIA
    bounds, clipping, and 96/144/192-DPI coverage.
  • Reuse the existing native Workspace menu command IDs for switching, New
    Workspace, and Manage Workspaces; hide the footer for a single default
    workspace and when the Sidebar is hidden.
  • Replace the previous x=250 workspace-switch UIA placeholders with one owned
    workspace-footer:<path> element in the actual Sidebar rail.
  • Add focused product/UIA contracts without changing terminal, canvas-card,
    dialog/NativeForms, Worktree, Activity, or GraphCanvas layout behavior.

Test plan

RED: & $env:GRAPHCODE_ZIG0152 test src\Sidebar.zig --test-filter "sidebar workspace footer" -target x86_64-windows-msvc -lc -luser32 -lgdi32 "-I$include" -> 0 passed, 1 failed at changed >= 24 because the production footer stub painted no control
GREEN: & $env:GRAPHCODE_ZIG0152 test src\Sidebar.zig --test-filter "sidebar workspace footer" -target x86_64-windows-msvc -lc -luser32 -lgdi32 "-I$include" -> 1/1 passed
REGRESSION: pwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -ShellPart unit -ShellTestShard 0 -ShellTestShardCount 3 -ShellTestManifest .ci-sections\shard-0.json, then shards 1 and 2 with the same command shape -> 23 + 18 + 25 = 66/66 sections passed on clean commit 5f9560a

Additional focused evidence:

  • MainWindow.zig --test-filter "workspace footer popup": 1/1 passed.
  • App footer visibility/production-paint/UIA test: 2/2 passed.
  • App DPI/UIA geometry test: 1/1 passed at 96, 144, and 192 DPI.
  • Full Sidebar: 247/247 passed.
  • Full MainWindow: 74/74 passed.
  • Full App root: 1,737 passed, 19 skipped, 0 failed.
  • Final ReleaseSafe Windows shell build: passed.
  • Footer-specific PowerShell UIA classifier/duplicate controls: 4/4 passed.
  • Exact clean-commit workflow unit shards: 23 assigned sections in shard 0,
    18 in shard 1, and 25 in shard 2; all executed with positive summaries.
  • git diff --check: clean. All touched files remain LF.

The broad ValidationRunner.Tests.ps1 execution remains stopped at a
pre-existing unrelated static regex mismatch: the test expects
Stop-Process -Id plus WINDOWS_SHELL_PRE_UIA_CLEANUP=verified, while current
validate.ps1 intentionally reports no_candidates_observed terminated=0
without terminating unowned processes. That blocker was preserved and was not
fixed in this PR.

Candidate and evidence identity

  • Tier(s): Tier A, Tier B
  • Branch: coneilen-plan-issue-767-sidebar-window-layout
  • HEAD / tree: 5f9560a / 991abc61632b3e0b59b167fffaea441b4285c0ac (clean)
  • Candidate hashes: graphcode-windows\zig-out\bin\graphcode-windows.exe=7C632EAA570EA297E1C06529F39F7121682572A04C587550467494D6D57C20A2; graphcode-windows\provider-pins.json=CAB4ADBEBBE44003CBB7691CA6EF8DE7FD05C780BB69561CDC60437244BD3902
  • Commit: signed with DCO and includes the Copilot co-author trailer.
  • Scope boundary: visible Sidebar footer/current-workspace action only.
    #767 stays open. No macOS-style workspace summary panel, native
    UIA/pointer walkthrough, paired visual parity, terminal reservation,
    worktree migration, Activity relocation, or whole-window closure is claimed.

Stopping handoff

  • Next exact command: Run the exact-head windows-shell workflow on the
    pushed candidate, then run the separately admitted Tier C UIA/pointer and
    paired macOS/Windows visual capture.
  • Positive count: 66/66 local workflow unit sections; 1,737 App tests
    passed, 19 skipped; 0 failures.
  • Permissions / time / desktop: Hosted PR CI and Tier C desktop lease are
    not available in this handoff; no live UIA or visual capture was run.
  • Blocker category: permissions/time/desktop
  • Evidence paths: session evidence logs
    windows-shell-shard-0.log, windows-shell-shard-1.log, and
    windows-shell-shard-2.log; exact commands and frozen candidate above.
  • Stopping condition: Exact-head PR workflows are green, then the named
    Tier C footer scenarios and paired captures are independently reviewed.
  • Publication authority: Coordinator only. This handoff does not authorize
    push, PR publication, merge, or parity-status promotion.

Checklist

  • I have read the Contributing Guidelines
  • I have signed off my commits (git commit -s) per the DCO
  • Tests pass locally using the Windows CI-equivalent shell unit commands
  • Code follows the existing style and the final ReleaseSafe build passes
  • I added the test/contract before the implementation and observed the
    intended RED failure
  • The evidence tier is explicit and the frozen candidate tuple matches the
    cited evidence
  • Any failure was classified and preserved before correction or retry

coneilen and others added 3 commits November 11, 2026 17:47
Signed-off-by: Colin Neilens <coneilen@microsoft.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@coneilen
coneilen merged commit 7394abf into main Nov 12, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant