Repository navigation
Add Windows sidebar workspace footer - #1008
Merged
Merged
Conversation
Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the visible, actionable workspace footer to the Windows sidebar and
reuses the existing native workspace lifecycle commands. This is a bounded
Refs #767slice for the footer/current-workspace action only; it does notclose the structured workspace-summary popover, whole-sidebar layout, terminal
reservation, or the issue's other acceptance boxes.
Changes
and disclosure chevrons inside the Sidebar's reserved 36-DIP bottom region.
bounds, clipping, and 96/144/192-DPI coverage.
Workspace, and Manage Workspaces; hide the footer for a single default
workspace and when the Sidebar is hidden.
workspace-footer:<path>element in the actual Sidebar rail.dialog/NativeForms, Worktree, Activity, or GraphCanvas layout behavior.
Test plan
RED: & $env:GRAPHCODE_ZIG0152 test src\Sidebar.zig --test-filter "sidebar workspace footer" -target x86_64-windows-msvc -lc -luser32 -lgdi32 "-I$include" -> 0 passed, 1 failed at changed >= 24 because the production footer stub painted no control
GREEN: & $env:GRAPHCODE_ZIG0152 test src\Sidebar.zig --test-filter "sidebar workspace footer" -target x86_64-windows-msvc -lc -luser32 -lgdi32 "-I$include" -> 1/1 passed
REGRESSION: pwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -ShellPart unit -ShellTestShard 0 -ShellTestShardCount 3 -ShellTestManifest .ci-sections\shard-0.json, then shards 1 and 2 with the same command shape -> 23 + 18 + 25 = 66/66 sections passed on clean commit 5f9560a
Additional focused evidence:
MainWindow.zig --test-filter "workspace footer popup": 1/1 passed.18 in shard 1, and 25 in shard 2; all executed with positive summaries.
git diff --check: clean. All touched files remain LF.The broad
ValidationRunner.Tests.ps1execution remains stopped at apre-existing unrelated static regex mismatch: the test expects
Stop-Process -IdplusWINDOWS_SHELL_PRE_UIA_CLEANUP=verified, while currentvalidate.ps1intentionally reportsno_candidates_observed terminated=0without terminating unowned processes. That blocker was preserved and was not
fixed in this PR.
Candidate and evidence identity
#767stays open. No macOS-style workspace summary panel, nativeUIA/pointer walkthrough, paired visual parity, terminal reservation,
worktree migration, Activity relocation, or whole-window closure is claimed.
Stopping handoff
windows-shellworkflow on thepushed candidate, then run the separately admitted Tier C UIA/pointer and
paired macOS/Windows visual capture.
passed, 19 skipped; 0 failures.
not available in this handoff; no live UIA or visual capture was run.
windows-shell-shard-0.log,windows-shell-shard-1.log, andwindows-shell-shard-2.log; exact commands and frozen candidate above.Tier C footer scenarios and paired captures are independently reviewed.
push, PR publication, merge, or parity-status promotion.
Checklist
git commit -s) per the DCOintended RED failure
cited evidence