Repository navigation
Restore Windows edge context menu summaries - #1010
Merged
Merged
Conversation
Show the macOS-style disabled summary before Delete Edge and retain Edit Edge as a Windows-only action. Own popup identity and summary across the native menu loop, and share the existing cycle-guard formatter without changing canvas rendering. Keep visual parity Partial pending paired native evidence. Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the missing macOS-style disabled summary in the Windows edge context menu, followed by Delete Edge and the explicitly retained Windows-only Edit Edge action. Existing quiet canvas labels, routing, styling and paint behavior are unchanged; visual parity remains Partial.
Relates to #765 and #728; this does not close their remaining live/visual qualification work.
Changes
Test plan
RED: & $env:GRAPHCODE_ZIG0152 test src\GraphContextMenu.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 "-I$include" --test-filter 'edge menu parity 765' -> behavioral failure: expected 3, found 2; 0 passed, 1 failed, preserved in edge-menu-red.log.
GREEN: & $env:GRAPHCODE_ZIG0152 test src\GraphContextMenu.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 "-I$include" --test-filter 'edge menu parity 765' -> 5 passed, preserved in edge-menu-green-attempt2.log.
REGRESSION: pwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -ShellPart unit -SwiftExecutable 'C:\Users\coneilen\AppData\Local\Programs\Swift\Toolchains\6.3.3+Asserts\usr\bin\swift.exe' -ShellValidationRoot D:\gc-765-validation-attempt3 -> exit 0; 66/66 sections selected; 86 successful Zig invocations containing 6754 passing test invocations and 39 skips; 157 Pester passes; 179 headless-selection and 280 accessibility-provider checks, zero unexpected failures.
The focused commands ran from
graphcode-windowsafter loading the repository-root.graphcode-tools\environment.ps1, setting$include = Join-Path $env:GRAPHCODE_WINGHOSTTY_ROOT 'include', and selecting the owned.build\issue765-tempand.build\issue765-zig-globaldirectories.The canonical unit run covers the same unit sections that CI divides into three shards; it does not replace CI or the separate integration lane. App actually executed: 1750 passed, 19 skipped, 0 failed. The complete menu root passed 297 tests; canvas passed 528 with 19 skips; standalone GDI+ passed 5 with 1 skip. Imported tests repeat, so the aggregate is not a distinct-test count.
The 39 skip occurrences are 19 canvas paint/card-chrome cases, their 19 App imports, and one standalone mapped-gradient/clip case. The worktree subprocess harness deliberately rejected four unknown scenarios: its four retained failure outputs are expected negative controls, and the harness passed with
requested=17; rejection=4; executed=21.Historical failures remain preserved:
ReadFailedwhile preparing pinned Breakpad; 32 completed Zig roots and 2265 pass invocations preceded the failure, but no App section ran. The separately admitted cache-only correction verified 923 files and left 14 protected files unchanged; it does not establish the underlying unpack-failure cause.No separate live/visual qualification ran. The canonical unit command includes its controlled GDI+ startup fixture (1 execution, 2 observations), not a paired macOS/Windows comparison. Shown popup behavior, native keyboard/pointer action outcomes, full selected/fired/guard/cycle visual states, release-build qualification and independent different-vendor visual review remain unqualified. The parity ledger stays Partial.
make testandmake checkwere not run on this Windows host; their template checkboxes remain unchecked.Candidate and evidence identity
The cited Tier A run occurred on
09519575b5952a87fc9c9c139a49ba7498053b05 / fe05c3b8cedd4d4bb46271ec610392349ba073fewith the five-file dirty candidate. All five source/document hashes and the provider-pin hash were verified unchanged against the frozen manifest before the single signed-off commit; staging and review did not change those bytes. This is not a claim that PR CI already passed on the new commit. Tier B is pending exact-head PR results; Tier C paired visual parity remains Partial.Stopping handoff
gh pr view coneilen-quiet-edges-behind-cards --repo scgopi/GraphCode --json url,headRefOid,statusCheckRollupfiles\edge-menu-red.log,files\edge-menu-green-attempt1.log,files\edge-menu-green-attempt2.log,files\edge-menu-regression.log,files\edge-menu-regression-attempt2.log,files\edge-canvas-regression.log,files\windows-unit-attempt1.log,files\windows-unit-attempt2.log,files\windows-unit-attempt3.log,files\breakpad-short-fetch-attempt1.log,files\edge-candidate-manifest.json; these local receipts are retained, not uploaded with this PR.The remaining scope/policy boundary concerns separately admitted visual qualification; it is not an outstanding Tier A product failure. Every exact-head PR workflow failure blocks merge, including non-required workflows.
Checklist
git commit -s) per the DCOmake test)make check)