Skip to content

Restore Windows edge context menu summaries - #1010

Merged
coneilen merged 1 commit into
mainfrom
coneilen-quiet-edges-behind-cards
Nov 12, 2026
Merged

coneilen merged 1 commit into
mainfrom
coneilen-quiet-edges-behind-cards

Conversation

@coneilen

Copy link
Copy Markdown
Collaborator

Summary

Restore the missing macOS-style disabled summary in the Windows edge context menu, followed by Delete Edge and the explicitly retained Windows-only Edit Edge action. Existing quiet canvas labels, routing, styling and paint behavior are unchanged; visual parity remains Partial.

Relates to #765 and #728; this does not close their remaining live/visual qualification work.

Changes

  • Capture owned project/edge identity and summary across the native popup message loop, with explicit capture-error reporting.
  • Format kind, condition, optional payload transform and cycle-guard/pass details; preserve Unicode and escape native menu mnemonics.
  • Move the existing guard-formatting helpers unchanged into GraphContextMenu and delegate the existing GraphCanvas call.
  • Update only the two admitted live-gate menu assertions and the edge-presentation ledger row. Add focused native-menu, ownership, malformed-input and allocation-unwind coverage.

Test plan

RED: & $env:GRAPHCODE_ZIG0152 test src\GraphContextMenu.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 "-I$include" --test-filter 'edge menu parity 765' -> behavioral failure: expected 3, found 2; 0 passed, 1 failed, preserved in edge-menu-red.log.
GREEN: & $env:GRAPHCODE_ZIG0152 test src\GraphContextMenu.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 "-I$include" --test-filter 'edge menu parity 765' -> 5 passed, preserved in edge-menu-green-attempt2.log.
REGRESSION: pwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -ShellPart unit -SwiftExecutable 'C:\Users\coneilen\AppData\Local\Programs\Swift\Toolchains\6.3.3+Asserts\usr\bin\swift.exe' -ShellValidationRoot D:\gc-765-validation-attempt3 -> exit 0; 66/66 sections selected; 86 successful Zig invocations containing 6754 passing test invocations and 39 skips; 157 Pester passes; 179 headless-selection and 280 accessibility-provider checks, zero unexpected failures.

The focused commands ran from graphcode-windows after loading the repository-root .graphcode-tools\environment.ps1, setting $include = Join-Path $env:GRAPHCODE_WINGHOSTTY_ROOT 'include', and selecting the owned .build\issue765-temp and .build\issue765-zig-global directories.

The canonical unit run covers the same unit sections that CI divides into three shards; it does not replace CI or the separate integration lane. App actually executed: 1750 passed, 19 skipped, 0 failed. The complete menu root passed 297 tests; canvas passed 528 with 19 skips; standalone GDI+ passed 5 with 1 skip. Imported tests repeat, so the aggregate is not a distinct-test count.

The 39 skip occurrences are 19 canvas paint/card-chrome cases, their 19 App imports, and one standalone mapped-gradient/clip case. The worktree subprocess harness deliberately rejected four unknown scenarios: its four retained failure outputs are expected negative controls, and the harness passed with requested=17; rejection=4; executed=21.

Historical failures remain preserved:

  • Canonical attempt1: environment/dependency unpack, ReadFailed while preparing pinned Breakpad; 32 completed Zig roots and 2265 pass invocations preceded the failure, but no App section ran. The separately admitted cache-only correction verified 923 files and left 14 protected files unchanged; it does not establish the underlying unpack-failure cause.
  • Canonical attempt2: scope/policy, candidate admission rejected the retained attempt1 validation root; zero tests executed. Attempt3 used a separately admitted fresh isolation parent without deleting the failed root.
  • Earlier GREEN/regression compile failures were test/harness failures (incorrect test snapshot fields and one missing required summary fixture), not behavioral evidence. The canvas root's successful alternate summary format also initially confused the count wrapper; the raw passing output was retained rather than relabeled.

No separate live/visual qualification ran. The canonical unit command includes its controlled GDI+ startup fixture (1 execution, 2 observations), not a paired macOS/Windows comparison. Shown popup behavior, native keyboard/pointer action outcomes, full selected/fired/guard/cycle visual states, release-build qualification and independent different-vendor visual review remain unqualified. The parity ledger stays Partial.

make test and make check were not run on this Windows host; their template checkboxes remain unchecked.

Candidate and evidence identity

  • Tier(s): Tier A
  • Branch: coneilen-quiet-edges-behind-cards
  • HEAD / tree: 94c1fbf / 48d0502460351eada84ae4c197f64421336c2c9c (clean)
  • Candidate hashes: provider-pins.json SHA256 C2B5B3CFE74C5BAE31D0CCEEBF02E363D113AFE4338E6D5E3DF2BB1E13672481; precommit patch SHA256 CD46495AA2DDB56B81B6AB544A478628227C6B127CD1AB82D70AA65CC7F1951E; passing canonical attempt3 log SHA256 A305A9052E009EC7F1805B92CB1CA8E11CCE03FD3A99D87B834A06D6C3A2A9C3.

The cited Tier A run occurred on 09519575b5952a87fc9c9c139a49ba7498053b05 / fe05c3b8cedd4d4bb46271ec610392349ba073fe with the five-file dirty candidate. All five source/document hashes and the provider-pin hash were verified unchanged against the frozen manifest before the single signed-off commit; staging and review did not change those bytes. This is not a claim that PR CI already passed on the new commit. Tier B is pending exact-head PR results; Tier C paired visual parity remains Partial.

Stopping handoff

  • Next exact command: gh pr view coneilen-quiet-edges-behind-cards --repo scgopi/GraphCode --json url,headRefOid,statusCheckRollup
  • Positive count: 6754 passing Zig test invocations across 86 successful invocations, 157 Pester passes, 179 headless-selection checks and 280 accessibility-provider checks; 39 skips; imports repeat.
  • Permissions / time / desktop: user authorized pushing this frozen commit and opening this PR; no source amendment, new live/visual lane or merge authorization.
  • Blocker category: scope/policy
  • Evidence paths: issue-session files\edge-menu-red.log, files\edge-menu-green-attempt1.log, files\edge-menu-green-attempt2.log, files\edge-menu-regression.log, files\edge-menu-regression-attempt2.log, files\edge-canvas-regression.log, files\windows-unit-attempt1.log, files\windows-unit-attempt2.log, files\windows-unit-attempt3.log, files\breakpad-short-fetch-attempt1.log, files\edge-candidate-manifest.json; these local receipts are retained, not uploaded with this PR.
  • Stopping condition: stop after publication and initial exact-head CI inspection; an empty CI result is not passing evidence. No merge or visual promotion.
  • Publication authority: push this reviewed branch and open this PR only; no amend, additional source changes, merge or remote/config changes.

The remaining scope/policy boundary concerns separately admitted visual qualification; it is not an outstanding Tier A product failure. Every exact-head PR workflow failure blocks merge, including non-required workflows.

Checklist

  • I have read the Contributing Guidelines
  • I have signed off my commits (git commit -s) per the DCO
  • Tests pass locally (make test)
  • Code follows the existing style (make check)
  • I added the test/contract before the implementation and observed the intended RED failure
  • The evidence tier is explicit and the frozen candidate tuple matches the cited evidence
  • Any failure was classified and preserved before correction or retry

Show the macOS-style disabled summary before Delete Edge and retain Edit Edge as a Windows-only action. Own popup identity and summary across the native menu loop, and share the existing cycle-guard formatter without changing canvas rendering. Keep visual parity Partial pending paired native evidence.

Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@coneilen
coneilen merged commit e9dacf0 into main Nov 12, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant