Repository navigation
Pin Windows Winghostty to the reviewed cursor-v3 revision - #1011
Merged
Merged
Conversation
Pin Winghostty to 4b48d90fd1c6658dfdaa588f2b2d685e52336030 with matching manifests, exact-pin contracts, current-production fixtures and provenance documentation. Clarify that ruleset 23625510 protects graphcode-host, not the publicly retained cursor branch. Add failure-only process-identity diagnostics without changing strict checks or cleanup. The single admitted V3 VisualBaseline run passed: 41 theme-validator calls, 51 rendered-validator calls and 8 static capture assertions; overlapping result assertions are not additive. The previous intermittent failure remains retained and its cause unresolved/unproven, not fixed. Other passing PreviewCore, ProviderPins, TerminalGate, extracted WindowsShell pin assertions and synthetic CanvasPaint results are V2 source-bound evidence, not V3 reruns. No native qualification or PR evidence is claimed. Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
coneilen
force-pushed
the
coneilen-terminal-provider-pin
branch
from
November 12, 2026 22:49
1411887 to
c713d91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin Windows Winghostty to the reviewed additive cursor revision
4b48d90fd1c6658dfdaa588f2b2d685e52336030, keeping current pin contracts and provenance consistent. This does not integrate new cursor behavior or establish native terminal qualification.Changes
23625510protectsgraphcode-host, not the publicly reachableconeilen-terminal-cursor-renderingbranch.Test plan
RED: pwsh -NoProfile -File Tools\windows\Tests\PreviewCore.Tests.ps1 -> exit 1, PreviewCore: accepted provider pins changed; intended stale current-good-case fixture mismatch at the intermediate V2 candidate, not runtime proof.
GREEN: pwsh -NoProfile -File C:\Users\coneilen.copilot\session-state\60dcc6f3-6ced-42dd-9f30-6dbe60618133\files\pin-v2-run-headless.ps1 -Suite PreviewCore -> exit 0, 37 cases; historical V2 source-bound evidence, not a V3 rerun or full packaging gate.
REGRESSION: pwsh -NoProfile -File C:\Users\coneilen.copilot\session-state\60dcc6f3-6ced-42dd-9f30-6dbe60618133\files\pin-v2-run-headless.ps1 -Suite ProviderPins -> exit 0, exactly 31 counted mutation/acceptance cases; historical V2 source-bound evidence, not a V3 rerun or full terminal gate.
Latest VisualBaseline command:
pwsh -NoProfile -File C:\Users\coneilen\.copilot\session-state\60dcc6f3-6ced-42dd-9f30-6dbe60618133\files\pin-v2-run-headless.ps1 -Suite VisualBaseline-> one admitted V3 default headless entrypoint, exit 0; 41 theme-validator calls, 51 rendered-validator calls and eight static capture assertions. Overlapping result counters (21 Assert-Passes and 64 Assert-Fails) are not additive. This ran before the local commit; reviewed committed source bytes match the V3 source seals, but no post-commit rerun is claimed.The preceding V2 VisualBaseline run failed with
String process timestamp identity failed. Its failure log is retained, and the root cause remains unresolved/unproven. Failure-only diagnostics did not fire in the single subsequent passing run; this is not evidence that the earlier intermittent failure was fixed.Other retained V2 results: TerminalGate 78 reported source/managed cases; CanvasPaint 11 synthetic log-parsing, eight converter and 22 scene-profile cases; seven AST-extracted existing WindowsShell pin assertions. These are historical source-bound constituent results, not current full-run qualification. ProviderPins' nested TerminalGate calls overlap and are not extra independent suite qualifications. Full WindowsShell entrypoints executed for that extracted assertion evidence: zero.
Full exact CI-equivalent pre-publication gates: NOT RUN / NOT SATISFIED. No complete shell shards/integration, provider build/live smoke, packaging contracts/real lifecycle, compiled validation host or full Windows spikes gate is claimed. The direct VisualBaseline pass omits the enclosing palette/full-workflow gates.
make testandmake checkwere not run.A request-bound native confirmation explicitly authorized the normal push and PR for this unchanged frozen commit, waiving completion of the exact-local-CI-equivalent/full-native pre-publication gates for this slice only. A second request-bound confirmation explicitly allowed the existing pre-push hook and configured checks AS-IS during that one normal push, without inspection, bypass, disablement or configuration changes. This relaxed the no-local-validation boundary only for checks reached by the exact normal push, not separate validation commands. Neither exception means the full gates passed, establishes Tier C qualification, waives server checks or authorizes merge. Exact-head PR CI is authoritative; every exact-head PR workflow failure blocks merge. No Tier B pass is claimed by this description.
Publication history: the original signed commit was first published once as
e8d0375566c258e02e6ae2df96f1ff94dc862242by a normal hook-inclusive push. GitHub Update branch then created an unsigned merge commit. DCO repair used object-onlygit replay --ref-action=printto write one signed-off/co-authored commitc713d9128f60edca109078f74f1be7c5bc8d11b7with sole parent currentmain, followed by exactly one SHA-boundgit push --force-with-leaseagainst expected remote head14118870a6de3e53184e40665de96b0b89d85216. Both repair commands exited 0; the existing hook ran as-is. The local worktree/index remained on historicale8d0375and were not modified. No separate validation command ran for the repair.Read-only verification: the repaired remote ref and PR head are
c713d9128f60edca109078f74f1be7c5bc8d11b7with treee5b6ca9c66778434ad28876941f9ffacb1424f90, whose sole parent is exact maine9dacf080fb12916ace34db3b220cacfe7223572. These are publication-identity observations, not validation results.A separate prerequisite-only SDK provisioning attempt failed, and its original guard exited without proving native cleanup: historical cleanup remains UNKNOWN. The SDK move failure and the precise native API/identity behind the original cleanup error remain unproven. No SDK, build, bootstrap, fixture, native inspection/termination or cleanup retry is part of this publication. Session-only custody-tooling revisions are independent of this commit; source review is not runtime qualification, and the missing concrete custody host/watchdog keeps that tooling execution-blocked. None of that tooling is included in this PR.
No cursor-pixel, blink/focus, WGL or backend-resize qualification is established. Unsupported password lock and cell-bottom underline limitations remain. Related to #736; its ledger status remains Partial, with no closure requested. #1009 appearance and current consumer behavior are unchanged.
Candidate and evidence identity
The index is clean; exactly three admitted baseline paths remain status-dirty but raw HEAD-identical and unchanged:
Tools\windows\Test-UiScenario.ps1,Tools\windows\Tests\Invoke-AgentCommand.Tests.ps1,Tools\windows\provider-build.ps1. None was committed or normalized. The twelve intended committed blobs match the reviewed V3 raw source hashes.V2/V3 execution occurred with parent HEAD
09519575b5952a87fc9c9c139a49ba7498053b05, treefe05c3b8cedd4d4bb46271ec610392349ba073fe, and their separately recorded dirty source manifests. Those results are not relabeled as execution on the later clean-index commit. The current commit's custody seal establishes source correspondence, not additional execution.Stopping handoff
git --no-pager show --format=fuller --stat c713d9128f60edca109078f74f1be7c5bc8d11b7for read-only review; exact-head PR CI results must be inspected separately before any merge decision.pin-v2-red.log,pin-v2-PreviewCore.log,pin-v2-ProviderPins.log,pin-v2-VisualBaseline.log,pin-v3-VisualBaseline-once.log,pin-v2-source-freeze.json,pin-v3-source-freeze.json,pin-local-commit-handoff.json,pin-prepush-admission-audit.md,pin-sdk-only-recovery-readonly-seal-2.json,pin-publication-hook-authorized-prepush.json,pin-publication-normal-push-1.stdout.log,pin-publication-normal-push-1.stderr.log,pin-publication-normal-push-1.json,pin-publication-remote-verification-1.json; all underC:\Users\coneilen\.copilot\session-state\60dcc6f3-6ced-42dd-9f30-6dbe60618133\files.Checklist
git commit -s) per the DCOmake test)make check)The evidence-identity checklist remains unchecked for complete current-candidate qualification: historical execution tuples and current source correspondence are explicitly separated above, and publication's narrow waiver does not complete the outstanding local/native qualification.