Skip to content

Fix year_low/year_high type annotations from int to Optional[int] #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chengjilai wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix year_low/year_high type annotations from int to Optional[int] #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scholarly/_scholarly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import pprint
import datetime
import re
from typing import Dict, List, Union
from typing import Dict, List, Optional, Union
from ._navigator import Navigator
from ._proxy_generator import ProxyGenerator
from dotenv import find_dotenv, load_dotenv
Expand Down Expand Up @@ -90,8 +90,8 @@ def set_timeout(self, timeout: int):

def search_pubs(self,
query: str, patents: bool = True,
citations: bool = True, year_low: int = None,
year_high: int = None, sort_by: str = "relevance",
citations: bool = True, year_low: Optional[int] = None,
year_high: Optional[int] = None, sort_by: str = "relevance",
include_last_year: str = "abstracts",
start_index: int = 0)->_SearchScholarIterator:
"""Searches by query and returns a generator of Publication objects
Expand Down Expand Up @@ -569,8 +569,8 @@ def download_mandates_csv(self, filename: str, overwrite: bool = False,

# TODO: Make it a public method in v1.6
def _construct_url(self, baseurl: str, patents: bool = True,
citations: bool = True, year_low: int = None,
year_high: int = None, sort_by: str = "relevance",
citations: bool = True, year_low: Optional[int] = None,
year_high: Optional[int] = None, sort_by: str = "relevance",
include_last_year: str = "abstracts",
start_index: int = 0)-> str:
"""Construct URL from requested parameters."""
Expand Down