Skip to content

docs: recommend persist-credentials false on checkout - #49

Merged
Joeri-Abbo merged 1 commit into
mainfrom
docs/checkout-persist-credentials
Sep 26, 2026
Merged

Joeri-Abbo merged 1 commit into
mainfrom
docs/checkout-persist-credentials

Conversation

@Joeri-Abbo

Copy link
Copy Markdown
Member

Summary

  • README usage example: set persist-credentials: false on actions/checkout and explain why.
  • Apply the same to this repo's own python.yml.

On tag builds the caller grants contents: write, and the same job runs pip install -r requirements.txt (unhashed), pytest, and pyinstaller. With the default checkout, the token sits in .git/config, where any installed package can read it. The action doesn't need git credentials; it gets the token through the token input only.

Found by a security scan (Low: defense in depth).

Test plan

  • python workflow passes on this PR

🤖 Generated with Claude Code

Third-party packages installed from requirements.txt run in the same job
that holds the release token. Keeping the token out of .git/config
limits what a compromised dependency can steal.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@Joeri-Abbo
Joeri-Abbo force-pushed the docs/checkout-persist-credentials branch from 43c89f3 to e820d7d Compare September 26, 2026 14:07
@Joeri-Abbo
Joeri-Abbo merged commit ea748b1 into main Sep 26, 2026
@Joeri-Abbo
Joeri-Abbo deleted the docs/checkout-persist-credentials branch September 26, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants