Repository navigation
Conversation
sbp-bvanb
left a comment
There was a problem hiding this comment.
🤖 pr-reviewer report
Branch: ci-enable-auto-release → main | Head: de7895a | Commits: 1 | Files: 1
Verdict: ✅ Approved
Adds .github/workflows/release.yml. On every push to main, it runs mcvs-general-action v0.9.0 with auto-release: "true", which creates the next semver tag and a GitHub Release from the Conventional Commits.
Checks
- Git: pass. Commit and PR title follow Conventional Commits. The description gives the reason and its claims hold:
mainis identical tov0.3.0, and the repo only allows squash merges, so thisci:title will not trigger a release. - Final newline: pass
- Pinning: pass (
4df2739…resolves tov0.9.0, whereauto-releaseis a real input;actions/checkoutuses the same SHA as the other workflows) - Correctness: pass.
contents: writeon the job only;concurrencyserialises releases; the action does its ownfetch-depth: 0checkout. Matches the upstream snippet apart from the v0.9.0 pin and the# yamllint disable-line rule:line-lengthcomment thatgeneral.ymlandmcvs-pr-validation.ymlalso use. - Security: pass (
persist-credentials: false, no secrets added) - Maintainability: pass
- Over-engineering: pass
- N/A: Terraform, Chef, Docker, Claude plugins
🤖 doc-reviewer report
Branch: ci-enable-auto-release → main | Head: de7895a | Docs: 0
Verdict: ❌ Changes requested
The PR adds only .github/workflows/release.yml. The root README.md it inherits from main has no ## Quickstart, and it carries the options reference and migration notes that belong in docs/, which does not exist.
Blocking
-
[quickstart]
README.md:10: no## Quickstartsection;## Usagealready has the concrete steps (lines 12-30), so renaming its heading fixes this.## Quickstart -
[lean]
README.md:32-70: the options table, usage notes and uv workspace example are reference material. Move them verbatim to a newdocs/configuration.mdunder# Configuration. -
[lean]
README.md:72-87: "Migrating to v0.3.0" belongs in a newdocs/migrating-to-v0.3.0.md. Replace it in the README with:## Documentation - [Configuration](docs/configuration.md) - [Migrating to v0.3.0](docs/migrating-to-v0.3.0.md)
Checks
- README: pass
- Quickstart: fail (
README.md:10) - Lean: fail (
README.md:32-70,README.md:72-87) - docs/ linked: pass (0 pages)
- Links: pass (2 checked)
🤖 dependency-reviewer report
Branch: ci-enable-auto-release → main | Head: de7895a | Dependencies: 3
Verdict: ✅ Approved
All pinned references in the new .github/workflows/release.yml are on their latest stable release, none are end-of-life, and Dependabot already covers the new workflow.
Checks
- Up to date: 3 (
actions/checkout@3d3c42e… # v7.0.1,schubergphilis/mcvs-general-action@4df2739… # v0.9.0,runs-on: ubuntu-24.04) - Outdated: 0
- EOL: 0
- Dependabot: the
github-actionsentry fordirectory: /hascooldownandgroups
🤖 github-actions-reviewer report
Branch: ci-enable-auto-release → main | Head: de7895a | Actions: 2
Verdict: ✅ Approved
Checks
- Pinning: pass (both
uses:pinned to a full 40-character SHA; no local ordocker://actions) - Version comments: pass (
v7.0.1andv0.9.0, lightweight tags) - Version precision: pass
Generated by mcvs_review 3.5.0 (pr-reviewer, doc-reviewer, dependency-reviewer, github-actions-reviewer) at commit de7895a.
|
Feedback from the mcvs_review summary:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
de7895a to
e96f7e5
Compare
Summary
Adds
.github/workflows/release.ymlfollowing mcvs-general-action's docs/auto-release.md, pinned to v0.9.0.Why: releases are tagged by hand today, so merged fixes and features wait until someone cuts a tag, and the version bump is a manual call. With this workflow every
feat:/fix:merge is released automatically, with the version derived from the commit messages.On every push to
mainit creates the next semver tag and a GitHub Release from the Conventional Commits since the latest tag (feat!:/BREAKING CHANGE:major,feat:minor,fix:/perf:patch, else nothing). The current latest tag isv0.3.0.On merge: no release yet.
mainhas nofeat:/fix:/perf:commits sincev0.3.0, and this PR's ownci:commit does not bump the version, so the nextfeat:/fix:merge cuts the first automatic release.🤖 Generated with Claude Code