Repository navigation
Conversation
github-actions
Bot
changed the title
|
The original issue asks for having the parameters on So instead I added a separate domain type that lists the important beamline parameters. |
| mean_L2=l2.nanmean(), | ||
| mean_Ltotal=ltotal.nanmean(), | ||
| mean_two_theta=two_theta.nanmean(), |
There was a problem hiding this comment.
Why do you need these here? You could compute these values when writing the file.
There was a problem hiding this comment.
Having the "typical" geometry values directly in the parameter is mainly for convenience.
| effective_chopper_position(choppers), source_position | ||
| ) | ||
| l2 = detector_ltotal - source_to_sample | ||
| ltotal = detector_ltotal - source_to_chopper |
There was a problem hiding this comment.
Remind me, don't you need these quantities for coordinate transforms? If so, you shouldn't compute them in two places.
| [ | ||
| chopper.axle_position | ||
| for name, chopper in choppers.items() | ||
| if not name.startswith('FC') |
There was a problem hiding this comment.
This seems more brittle than looking for specific names. If the names change in the file, you silently average the wrong positions with the current implementation. If you look for specific names to include (instead of exclude) the workflow will fail visibly when something gets renamed.
Fixes #744