Skip to content

Feat/scribe server localization 112#619

Closed
prince-0408 wants to merge 0 commit into
scribe-org:mainfrom
prince-0408:feat/scribe-server-localization-112
Closed

Feat/scribe server localization 112#619
prince-0408 wants to merge 0 commit into
scribe-org:mainfrom
prince-0408:feat/scribe-server-localization-112

Conversation

@prince-0408

Copy link
Copy Markdown
Contributor

Description

Closes scribe-org/Scribe-i18n#112

Full audit and localization of all hard-coded user-facing strings in the
Android app. Every string now comes from string.xml via stringResource()
or getString().

Depends on scribe-org/Scribe-i18n#114 merging first.

Scribe-Server API messages (core ask)

Both DataDownloadViewModel and ConjugateDataDownloadViewModel now use
localized strings for all 9 server-response Toast messages:

  • server.download_successful / server.conjugate_download_successful
  • server.already_up_to_date / server.already_up_to_date_lang / server.conjugate_already_up_to_date_lang
  • server.error_network / server.error_database / server.error_server / server.error_timeout

Files changed (21)

DownloadDataDownloadViewModel, ConjugateDataDownloadViewModel, DataDownloadScreen, ConjugateDownloadDataScreen

TutorialTutorialContent (refactored to metadata only), TutorialNavigator (builds localized chapters), TutorialHomeScreen, TutorialStepScreen, WrongKeyboardScreen

HelpersShareHelper, RatingHelper

Common componentsActionBar, ConfirmationDialog, HintDialog, CircleClickableItemComp, DownloadDataOptionComp, ClickableItemComp, AboutPageItemComp, InstallationScreen, ConjugateScreen

Resourcesstring.xml: 55 new entries, unused all_languages key removed

Verification

  • 172 R.string references — all resolve ✓
  • Zero hard-coded Toast messages ✓
  • Zero hard-coded text = or contentDescription = literals ✓

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@prince-0408 prince-0408 force-pushed the feat/scribe-server-localization-112 branch from 2f670a7 to 2715b0c Compare June 15, 2026 17:11
@prince-0408 prince-0408 deleted the feat/scribe-server-localization-112 branch June 15, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add strings for Scribe-Server related messages to the user

1 participant