Feat/scribe server localization 112#619
Closed
prince-0408 wants to merge 0 commit into
Closed
Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
2f670a7 to
2715b0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes scribe-org/Scribe-i18n#112
Full audit and localization of all hard-coded user-facing strings in the
Android app. Every string now comes from
string.xmlviastringResource()or
getString().Scribe-Server API messages (core ask)
Both
DataDownloadViewModelandConjugateDataDownloadViewModelnow uselocalized strings for all 9 server-response Toast messages:
server.download_successful/server.conjugate_download_successfulserver.already_up_to_date/server.already_up_to_date_lang/server.conjugate_already_up_to_date_langserver.error_network/server.error_database/server.error_server/server.error_timeoutFiles changed (21)
Download —
DataDownloadViewModel,ConjugateDataDownloadViewModel,DataDownloadScreen,ConjugateDownloadDataScreenTutorial —
TutorialContent(refactored to metadata only),TutorialNavigator(builds localized chapters),TutorialHomeScreen,TutorialStepScreen,WrongKeyboardScreenHelpers —
ShareHelper,RatingHelperCommon components —
ActionBar,ConfirmationDialog,HintDialog,CircleClickableItemComp,DownloadDataOptionComp,ClickableItemComp,AboutPageItemComp,InstallationScreen,ConjugateScreenResources —
string.xml: 55 new entries, unusedall_languageskey removedVerification
R.stringreferences — all resolve ✓text =orcontentDescription =literals ✓