#686 Update project structure and docs for project#702
Conversation
Thank you for the pull request! 💙🩵The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
@axif0, this is a refactor I realized that we should do when looking into #701 (closed as I think it's fine that we keep the output directories so the tests can use other directories). We have one failing test on Ubuntu, which maybe you'd have an idea on. Aside from that, could you verify that the modularization makes sense to you and make any suggestions that come to mind? I'll do the remaining work for #686 here. If you wanted to give another pass of the docs, and commit any changes you think are needed, then that'd also be much appreciated 😊 After this is in I'll focus on #617 and #669 :) CC @DeleMike 👋 |
|
Per discussions in the sync, @DeleMike, the documentation to look at would be:
CC @axif0 👋 |
|
will work on it :) |
|
Thanks for the test fix, @axif0! I knew it was something simple like that :) :) |
| @@ -0,0 +1,8 @@ | |||
| utils.py | |||
There was a problem hiding this comment.
| utils.py | |
| check.py |
| was_or_were = "was" if len(not_included_isos) == 1 else "were" | ||
| rprint( | ||
| f"[bold green]The following {iso_or_isos} {was_or_were} successfully downloaded: {', '.join(not_included_isos)}[/bold green]" | ||
| ) |
There was a problem hiding this comment.
Isn't this should be language_isos ? like -
| was_or_were = "was" if len(not_included_isos) == 1 else "were" | |
| rprint( | |
| f"[bold green]The following {iso_or_isos} {was_or_were} successfully downloaded: {', '.join(not_included_isos)}[/bold green]" | |
| ) | |
| iso_or_isos = "iso" if len(language_isos) == 1 else "isos" | |
| was_or_were = "was" if len(language_isos) == 1 else "were" | |
| rprint( | |
| f"[bold green]The following {iso_or_isos} {was_or_were} successfully downloaded: {', '.join(language_isos)}[/bold green]" | |
| ) |
Contributor checklist
pytestcommand as directed in the testing section of the contributing guideDescription
Follows #701 and #696 being declined. This PR will restructure the project to make it more modular and then update the docs :)
Related issue