Skip to content

#686 Update project structure and docs for project#702

Open
andrewtavis wants to merge 13 commits into
mainfrom
686-update-structure-and-docs
Open

#686 Update project structure and docs for project#702
andrewtavis wants to merge 13 commits into
mainfrom
686-update-structure-and-docs

Conversation

@andrewtavis

@andrewtavis andrewtavis commented Jun 12, 2026

Copy link
Copy Markdown
Member

Contributor checklist


Description

Follows #701 and #696 being declined. This PR will restructure the project to make it more modular and then update the docs :)

Related issue

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for the pull request! 💙🩵

The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Data rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the pytest, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis requested a review from axif0 June 12, 2026 23:03
@andrewtavis

andrewtavis commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

@axif0, this is a refactor I realized that we should do when looking into #701 (closed as I think it's fine that we keep the output directories so the tests can use other directories). We have one failing test on Ubuntu, which maybe you'd have an idea on. Aside from that, could you verify that the modularization makes sense to you and make any suggestions that come to mind?

I'll do the remaining work for #686 here. If you wanted to give another pass of the docs, and commit any changes you think are needed, then that'd also be much appreciated 😊

After this is in I'll focus on #617 and #669 :)

CC @DeleMike 👋

@andrewtavis andrewtavis requested a review from DeleMike June 13, 2026 14:21
@andrewtavis

Copy link
Copy Markdown
Member Author

Per discussions in the sync, @DeleMike, the documentation to look at would be:

CC @axif0 👋

@andrewtavis

Copy link
Copy Markdown
Member Author

Would be good if all three of the above files are checked by @DeleMike, @axif0 and I :)

@DeleMike

Copy link
Copy Markdown
Collaborator

will work on it :)

@andrewtavis

Copy link
Copy Markdown
Member Author

Thanks for the test fix, @axif0! I knew it was something simple like that :) :)

@@ -0,0 +1,8 @@
utils.py

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
utils.py
check.py

Comment on lines +127 to +130
was_or_were = "was" if len(not_included_isos) == 1 else "were"
rprint(
f"[bold green]The following {iso_or_isos} {was_or_were} successfully downloaded: {', '.join(not_included_isos)}[/bold green]"
)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this should be language_isos ? like -

Suggested change
was_or_were = "was" if len(not_included_isos) == 1 else "were"
rprint(
f"[bold green]The following {iso_or_isos} {was_or_were} successfully downloaded: {', '.join(not_included_isos)}[/bold green]"
)
iso_or_isos = "iso" if len(language_isos) == 1 else "isos"
was_or_were = "was" if len(language_isos) == 1 else "were"
rprint(
f"[bold green]The following {iso_or_isos} {was_or_were} successfully downloaded: {', '.join(language_isos)}[/bold green]"
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scribe-Data markdown and rst documentation check

3 participants