修复 sandbox iframe 使用 display: none 导致的问题#1478
Open
cyfung1031 wants to merge 1 commit into
Open
Conversation
Member
|
"可能会影响 sandbox 页面的正常加载或通信行为" 这个是哪里的结论,实际上有这个问题?会出现? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
描述
本次修改调整了 sandbox iframe 的隐藏方式,避免直接使用
display: none。之前 iframe 通过内联样式
display: none隐藏,可能会影响 sandbox 页面的正常加载或通信行为。现在改为使用 CSS 类将 iframe 缩小到 1px、设置透明、禁用交互并裁剪显示区域,在视觉上隐藏 iframe 的同时,仍保留其正常存在于页面中的行为。同时为 iframe 增加了
aria-hidden="true"和tabindex="-1",避免其被辅助技术读取或通过键盘聚焦。主要变更
style="display: none".sandbox-iframe样式用于视觉隐藏 iframearia-hidden="true"和tabindex="-1"测试