Repository navigation
chore(lint): enable Oxlint suspicious and perf rules - #1136
Merged
Merged
Conversation
Supersedes #1132, rebased onto main after React 19 and the Motion demos landed. Replaces the new unsafe type assertion in ExampleElAnimate with an instanceof guard. Co-authored-by: tembo[bot] <208362400+tembo-io[bot]@users.noreply.github.com> Co-authored-by: Cody Olsen <stipsan@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1132 (by @stipsan / Tembo). After React 19 (#1135) and the Motion demos (#1130) landed, #1132 conflicted and failed
vp check: its newno-unsafe-type-assertionrule flagsel.firstElementChild as HTMLElementinExampleElAnimate.tsx, which #1130 added.Changes on top of #1132:
ExampleCustomTransition.tsxkeeps feat: demo custom transitions with Motion and el.animate #1130's version, since the Popmotion/Stylefire code chore(lint): enable Oxlint suspicious and perf rules #1132 linted was removed.ExampleElAnimatenow guardsfirstElementChildwithinstanceof HTMLElementinstead of asserting it.Verified locally:
vp check,vp exec knip,vp run typecheckandvp run buildpass.