Repository navigation
fix(benches): honor RUST_MIN_STACK for weierstrass Criterion mains - #1405
Open
kutluhaneth46 wants to merge 1 commit into
Open
kutluhaneth46 wants to merge 1 commit into
kutluhaneth46 wants to merge 1 commit into
Conversation
Criterion's generated main does not pick up RUST_MIN_STACK. Share a helper that spawns the bench runner on a thread with the env-configured (or default 32MiB) stack size. Fixes scroll-tech#1075
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RUST_MIN_STACKand linker stack-size flags do not affect Criterion'''s generatedmain. This adds a shared bench helper that spawns the runner on a thread withRUST_MIN_STACK(or a 32MiB default) and wires weierstrass add/double benches through it.Usage:
Test plan
cargo bench -p ceno_zkvm --bench weierstrass_add -- --test(or smoke run)Fixes #1075