Bump tutorials submodule for the full-dataset milo notebook#1040
Merged
Conversation
Bumps docs/tutorials/notebooks to scverse/pertpy-tutorials#68. That PR runs the Milo DA tutorial on the full dataset so the differential-abundance plots render again; the 10k subsample left too few neighbourhoods to clear the notebook's significance thresholds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1040 +/- ##
=======================================
Coverage 77.99% 77.99%
=======================================
Files 50 50
Lines 6694 6694
=======================================
Hits 5221 5221
Misses 1473 1473 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
docs/tutorials/notebookssubmodule to the latestpertpy-tutorialsmain (scverse/pertpy-tutorials#68, merged).That PR drops the 10k subsample from the Milo DA tutorial's main analysis and re-executes on the full dataset, restoring the differential-abundance plots that were rendering empty — the subsample left only ~575 neighbourhoods versus 4307 on the full dataset, too few to clear the notebook's significance thresholds (
SpatialFDR < 0.1 & Plasmablast,SpatialFDR < 0.01 & logFC > 2).This is affordable now that
da_nhoodsis ~100x faster viasize_factors_fit_type="poscounts"(#992).Submodule pointer:
8789a03→817d28b.🤖 Generated with Claude Code