fix transform points with duplicate indices#1129
Merged
Merged
Conversation
…ndex dd.from_delayed starts with empty attrs, so spatialdata_attrs (feature_key, instance_key) was silently dropped. Copy all non-transform attrs from the original element to restore the previous behaviour. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
=======================================
Coverage 92.27% 92.28%
=======================================
Files 51 51
Lines 7797 7804 +7
=======================================
+ Hits 7195 7202 +7
Misses 602 602
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1105
The problem is that transcripts given by
spatialdata_io.xenium()have non-unique indices across partitions (no table is annotating them, so uniqueness is not necessary).The preserves the indices upon transformation.