Skip to content

Remove unused DataStax Insights monitoring - #1035

Open
dkropachev wants to merge 1 commit into
scylla-4.xfrom
cleanup/1027-remove-insights
Open

Remove unused DataStax Insights monitoring#1035
dkropachev wants to merge 1 commit into
scylla-4.xfrom
cleanup/1027-remove-insights

Conversation

@dkropachev

Copy link
Copy Markdown

Closes #1027. Part of #1025.

What and why

Remove the DataStax Insights client, lifecycle listener, schemas, monitoring option, tests, fixtures, and generated dependency-report files. ScyllaDB does not use or test Insights, so this removes background production behavior and test/build code that the team otherwise has to support without coverage.

Client/application STARTUP metadata and Scylla driver-config reporting are preserved because they have non-Insights consumers.

Validation

  • mvn -pl core,query-builder,mapper-runtime,mapper-processor clean test — 4,571 tests, no failures or errors.
  • mvn -pl integration-tests -am -DskipTests test-compile

Dependencies: none. Cherry-picked commits: none.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 52 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: 3c13d05d-5ccf-49d6-9cce-bbdc45da43ed

📥 Commits

Reviewing files that changed from the base of the PR and between dc58ee9 and a9b72c6.

📒 Files selected for processing (65)
  • changelog/README.md
  • core/pom.xml
  • core/src/main/java/com/datastax/dse/driver/api/core/config/DseDriverOption.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/InsightsClientLifecycleListener.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/AddressFormatter.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/ConfigAntiPatternsFinder.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/DataCentersFinder.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/ExecutionProfilesInfoFinder.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/InsightsClient.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/InsightsSupportVerifier.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/PackageUtil.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/PlatformInfoFinder.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/ReconnectionPolicyInfoFinder.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/configuration/InsightsConfiguration.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/exceptions/InsightEventFormatException.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/AuthProviderType.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/Insight.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/InsightMetadata.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/InsightType.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/InsightsPlatformInfo.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/InsightsStartupData.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/InsightsStatusData.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/LoadBalancingInfo.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/PoolSizeByHostDistance.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/ReconnectionPolicyInfo.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/SSL.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/SessionStateForNode.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/SpecificExecutionProfile.java
  • core/src/main/java/com/datastax/dse/driver/internal/core/insights/schema/SpeculativeExecutionInfo.java
  • core/src/main/java/com/datastax/oss/driver/api/core/config/OptionsMap.java
  • core/src/main/java/com/datastax/oss/driver/api/core/config/TypedDriverOption.java
  • core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/context/DefaultDriverContext.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/context/InternalDriverContext.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/context/NoopDriverConfigReporter.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/context/StartupOptionsBuilder.java
  • core/src/main/resources/reference.conf
  • core/src/test/java/com/datastax/dse/driver/internal/DependencyCheckTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/DependencyCheckTestBase.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/insights/AddressFormatterTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/insights/ConfigAntiPatternsFinderTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/insights/DataCentersFinderTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/insights/ExecutionProfileMockUtil.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/insights/ExecutionProfilesInfoFinderTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/insights/InsightsClientTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/insights/InsightsSupportVerifierTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/insights/PackageUtilTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/insights/PlatformInfoFinderTest.java
  • core/src/test/java/com/datastax/dse/driver/internal/core/insights/ReconnectionPolicyInfoFinderTest.java
  • core/src/test/resources/insights/duplicate-dependencies.txt
  • core/src/test/resources/insights/malformed-pom.properties
  • core/src/test/resources/insights/netty-dependency-optional.txt
  • core/src/test/resources/insights/netty-dependency.txt
  • core/src/test/resources/insights/ordered-dependencies.txt
  • core/src/test/resources/insights/pom.properties
  • core/src/test/resources/insights/test-dependencies.txt
  • integration-tests/src/test/java/com/datastax/dse/driver/api/core/insights/InsightsClientIT.java
  • integration-tests/src/test/java/com/datastax/oss/driver/internal/core/util/concurrent/DriverBlockHoundIntegrationCcmIT.java
  • manual/core/integration/README.md
  • mapper-processor/pom.xml
  • mapper-processor/src/test/java/com/datastax/dse/driver/internal/mapper/processor/DependencyCheckTest.java
  • mapper-runtime/pom.xml
  • mapper-runtime/src/test/java/com/datastax/dse/driver/api/mapper/DependencyCheckTest.java
  • query-builder/pom.xml
  • query-builder/src/test/java/com/datastax/dse/driver/internal/querybuilder/DependencyCheckTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove DataStax Insights monitoring

1 participant