Remove unused DSE data types - #1039
Conversation
|
Important Review skippedToo many files! This PR contains 251 files, which is 151 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (251)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
81a3e78 to
1b0618c
Compare
|
I understand the motivation, but what if someone uses the driver during a migration? I suppose one can use the DSE driver for one cluster and our driver for another with some shady "shading" tricks. |
Exactly, they will have to shade it. |
Closes #1029. Part of #1025.
What and why
Remove DSE geometry and DateRange APIs, codecs, tests, OSGi fixtures, and the ESRI/legacy JSON dependency chain. ScyllaDB does not use or test these types, so deleting them reduces unsupported production and test code.
Dependency and rebase
This PR depends on #1036 and includes its exact current Graph-removal commit
aa660cfc5a. The type-removal commit is1b0618c6a0. After #1036 merges, rebase ontoscylla-4.x, dropaa660cfc5a, and retain/reapply1b0618c6a0.Validation
mvn -pl core clean test— 3,555 tests, no failures or errorsmvn -pl integration-tests,osgi-tests -am -DskipTests test-compilemvn -DskipTests install— full 17-module reactor, including shaded and distribution packaging